Update code according to PR reviews

LiskArchive · Oct 20, 2022 · d9a7351 · d9a7351
1 parent de12483
commit d9a7351
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/elements/lisk-chain/src/index.ts b/elements/lisk-chain/src/index.ts
@@ -29,6 +29,11 @@ export {
 	EVENT_MAX_EVENT_SIZE_BYTES,
 	MAX_EVENTS_PER_BLOCK,
 	EVENT_KEY_LENGTH,
+	NAME_REGEX,
+	MAX_CROSS_CHAIN_COMMAND_NAME_LENGTH,
+	MAX_MODULE_NAME_LENGTH,
+	MIN_CROSS_CHAIN_COMMAND_NAME_LENGTH,
+	MIN_MODULE_NAME_LENGTH,
 } from './constants';
 export * from './db_keys';
 export type { RawBlock } from './types';

diff --git a/framework/src/modules/interoperability/schemas.ts b/framework/src/modules/interoperability/schemas.ts
@@ -17,7 +17,7 @@ import {
 	MAX_MODULE_NAME_LENGTH,
 	MIN_CROSS_CHAIN_COMMAND_NAME_LENGTH,
 	MIN_MODULE_NAME_LENGTH,
-} from '@liskhq/lisk-chain/dist-node/constants';
+} from '@liskhq/lisk-chain';
 import { CHAIN_ID_LENGTH } from '../token/constants';
 import {
 	MAX_LENGTH_NAME,

diff --git a/framework/src/modules/interoperability/utils.ts b/framework/src/modules/interoperability/utils.ts
@@ -17,7 +17,7 @@ import { codec } from '@liskhq/lisk-codec';
 import { utils, bls } from '@liskhq/lisk-cryptography';
 import { validator } from '@liskhq/lisk-validator';
 import { dataStructures } from '@liskhq/lisk-utils';
-import { NAME_REGEX } from '@liskhq/lisk-chain/dist-node/constants';
+import { NAME_REGEX } from '@liskhq/lisk-chain';
 import {
 	ActiveValidators,
 	CCMsg,
@@ -94,7 +94,7 @@ export const validateFormat = (ccm: CCMsg) => {
 	}
 
 	if (serializedCCM.byteLength > MAX_CCM_SIZE) {
-		throw new Error(`Cross chain message is over the the max ccm size limit of ${MAX_CCM_SIZE}`);
+		throw new Error(`Cross chain message is over the the max CCM size limit of ${MAX_CCM_SIZE}`);
 	}
 };
 

diff --git a/framework/test/unit/modules/interoperability/utils.spec.ts b/framework/test/unit/modules/interoperability/utils.spec.ts
@@ -2142,6 +2142,7 @@ describe('Utils', () => {
 			sendingChainID: obj.sendingChainID ?? cryptography.utils.intToBuffer(20, 4),
 			status: obj.status ?? CCM_STATUS_OK,
 		});
+
 		it('should throw if format does not fit ccmSchema', () => {
 			expect(() =>
 				validateFormat(
@@ -2151,6 +2152,7 @@ describe('Utils', () => {
 				),
 			).toThrow("Property '.module' must NOT have fewer than 1 characters");
 		});
+
 		it('should throw if module does not pass Regex', () => {
 			expect(() =>
 				validateFormat(
@@ -2160,6 +2162,7 @@ describe('Utils', () => {
 				),
 			).toThrow('Cross-chain message module name must be alphanumeric.');
 		});
+
 		it('should throw if crossChainCommand does not pass Regex', () => {
 			expect(() =>
 				validateFormat(
@@ -2169,15 +2172,17 @@ describe('Utils', () => {
 				),
 			).toThrow('Cross-chain message crossChainCommand name must be alphanumeric.');
 		});
+
 		it('should throw if byteLength exceeds MAX_CCM_SIZE', () => {
 			expect(() =>
 				validateFormat(
 					buildCCM({
 						params: Buffer.alloc(MAX_CCM_SIZE + 100),
 					}),
 				),
-			).toThrow(`Cross chain message is over the the max ccm size limit of ${MAX_CCM_SIZE}`);
+			).toThrow(`Cross chain message is over the the max CCM size limit of ${MAX_CCM_SIZE}`);
 		});
+
 		it('should pass validateFormat check', () => {
 			expect(() => validateFormat(buildCCM({}))).not.toThrow();
 		});