Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix lisk-client export - Closes #7338 #7390

Merged
merged 5 commits into from
Aug 15, 2022
Merged

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Aug 10, 2022

What was the problem?

This PR resolves #7338

How was it solved?

  • main is used mainly for library, so updating the default to node.js version
  • Add browser field to specify the usage during the browser build
  • Update plugin bundles to parcels to read the browser field and make it easy to update the version

How was it tested?

  • Run npm run start:web on faucet plugin and ensure UI build is working
  • Check lisk-client/index.html and see lisk is usable in the browser console

@shuse2 shuse2 self-assigned this Aug 10, 2022
@shuse2 shuse2 force-pushed the 7338-fix_lisk_client_export branch from e52f0f9 to f16a457 Compare August 10, 2022 21:02
@shuse2 shuse2 force-pushed the 7338-fix_lisk_client_export branch from 74413cf to 982168f Compare August 11, 2022 09:49
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Ran faucet plugin and it builds and loads without any error
  • Tested lisk-client/index.html where lisk is accessible with all the expected objects

@shuse2 shuse2 merged commit a51faa5 into development Aug 15, 2022
@shuse2 shuse2 deleted the 7338-fix_lisk_client_export branch August 15, 2022 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lisk desktop tests fail when lisk-client is updated to v6
3 participants