Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Lisk desktop tests fail when lisk-client is updated to v6 #7338

Closed
Tracked by #7210
ManuGowda opened this issue Jul 26, 2022 · 1 comment · Fixed by #7390
Closed
Tracked by #7210

Lisk desktop tests fail when lisk-client is updated to v6 #7338

ManuGowda opened this issue Jul 26, 2022 · 1 comment · Fixed by #7390
Assignees
Milestone

Comments

@ManuGowda
Copy link
Contributor

Expected behavior

Configure Lisk desktop tests environment to handle buffer for both browser and nodejs

Actual behavior

  • When we update lisk-client dependency to its latest version the tests starts to fail
  • The root cause of failing tests are due to the changes in the way lisk-client is being shipped from version >= v6
    • The global buffer is an instance of browser buffer f0c25ef
    • Since the jest setup is configured to work with nodejs buffer, if we update lisk-client to its latest version the lisk-client functions starts to fail

Steps to reproduce

  • Checkout development branch
  • Update lisk-client to latest version v6
  • Run npm install
  • Run npm run test

Which version(s) does this affect? (Environment, OS, etc...)

Lisk Desktop v3

@ManuGowda ManuGowda transferred this issue from LiskHQ/lisk-desktop Jul 26, 2022
@shuse2 shuse2 added this to the Sprint 74 milestone Jul 29, 2022
@shuse2 shuse2 self-assigned this Jul 29, 2022
@shuse2 shuse2 removed this from the Sprint 74 milestone Jul 29, 2022
@shuse2
Copy link
Collaborator

shuse2 commented Jul 29, 2022

The main reason why browser became default is we use the browser version in faucet and dashboard plugins and they are working.
It doesn't work with node version because dashboard/faucet do not have bundler setting
exports field is currently not working well in TypeScript.

If we change the default back

  • Make sure faucet/dashboard plugin UI works as it is. (maybe we just need bundler to resolve)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants