Remove passphrase handling from cryptography - Closes #7291, #6864,#7332 #7364

shuse2 · 2022-08-01T19:57:26Z

This PR resolves #7291, resolves #6864, resolves #7332

Remove functions which has input of passphrase and has corresponding function with private key
Update functions only take passphrase to take private key
Update all other package to use private key functions
Update commander to take key-derivation-path with passphrase

Check the exposed functions. Especially, lisk-cryptography should not have function with passphrase
All test and build should work

elements/lisk-transactions/src/sign.ts

mosmartin

LGTM 🚀

shuse2 added 2 commits August 1, 2022 19:06

♻️ Remove cryptography functions which uses passphrase as input

bbee823

🌱 Update usage

5c3dc39

shuse2 self-assigned this Aug 1, 2022

✅ Update unit tests to apply breaking changes

6ad685b

shuse2 force-pushed the 7332-remove_passphrase_handling branch from bc6f06b to 6ad685b Compare August 3, 2022 07:04

shuse2 commented Aug 3, 2022

View reviewed changes

elements/lisk-transactions/src/sign.ts Show resolved Hide resolved

elements/lisk-transactions/src/sign.ts Show resolved Hide resolved

shuse2 requested review from Incede and mosmartin August 3, 2022 07:08

Merge branch 'development' into 7332-remove_passphrase_handling

080d3fb

mosmartin reviewed Aug 4, 2022

View reviewed changes

mosmartin approved these changes Aug 4, 2022

View reviewed changes

shuse2 requested review from ishantiw and removed request for Incede August 5, 2022 10:37

ishantiw approved these changes Aug 5, 2022

View reviewed changes

shuse2 merged commit d03d141 into development Aug 5, 2022

shuse2 deleted the 7332-remove_passphrase_handling branch August 5, 2022 14:31

Provide feedback