Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix getMetadata response and socket ipc data path- Closes #7172,#7236 #7234

Merged
merged 5 commits into from
Jun 23, 2022
Merged

Fix getMetadata response and socket ipc data path- Closes #7172,#7236 #7234

merged 5 commits into from
Jun 23, 2022

Conversation

ishantiw
Copy link
Contributor

@ishantiw ishantiw commented Jun 21, 2022 •
edited
Loading

What was the problem?

This PR resolves #7172 & #7236

How was it solved?

How was it tested?

  • Run npm t under elements/lisk-api-client
  • Create an API client using createIPCClient and run a node with with --api-ipc enabled. check if it gets connected successfully and is able to call system_getMetadata endpoint.

@ishantiw ishantiw self-assigned this Jun 21, 2022
@mitsuaki-u mitsuaki-u self-requested a review June 22, 2022 07:33
@milenagojkovic milenagojkovic requested review from has5aan and sitetester and removed request for mitsuaki-u June 22, 2022 07:47
has5aan
has5aan approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@has5aan has5aan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Passing tests.
  • APIClient retrieves metadata (configured modules) at initialization upon manual testing with both lisk-core-v4.0.0-alpha.0 and examples\dpos-mainchain which fixes IPC connection to dpos-mainchain.

@ishantiw ishantiw merged commit 370d2c4 into development Jun 23, 2022
@ishantiw ishantiw deleted the 7172-unable-post-transaction branch June 23, 2022 09:42
@ishantiw ishantiw changed the title Fix getMetadata response and socket ipc data path- Closes #7172 Fix getMetadata response and socket ipc data path- Closes #7172,#7236 Jun 23, 2022
@ishantiw ishantiw linked an issue Jun 23, 2022 that may be closed by this pull request
Enable ipc api is not working for example dpos-mainchain #7236
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sitetester sitetester sitetester approved these changes

@has5aan has5aan has5aan approved these changes

Assignees

@ishantiw ishantiw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable ipc api is not working for example dpos-mainchain Unable to post transactions against v6 node
3 participants
@ishantiw @sitetester @has5aan