Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement fee module verifyTransaction hook - Closes #6693 #6705

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Implement fee module verifyTransaction hook - Closes #6693 #6705

merged 3 commits into from
Sep 1, 2021

Conversation

mitsuaki-u
Copy link
Contributor

What was the problem?

This PR resolves #6693

How was it solved?

🌱 3428ef1

  • Implemented verifyTransaction hook
  • Added extraFee method

🌱 cff28c7

  • Added unit tests for init hook
  • Added unit tests for verifyTransaction hook Please describe your technical implementation -->

How was it tested?

Added unit tests

@mitsuaki-u mitsuaki-u self-assigned this Sep 1, 2021
shuse2
shuse2 suggested changes Sep 1, 2021
View reviewed changes
framework/test/unit/modules/fee/fee_module.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/fee/fee_module.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/fee/fee_module.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/fee/fee_module.spec.ts Outdated Show resolved Hide resolved
ishantiw
ishantiw approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments from @shuse2 , LGTM

@shuse2 shuse2 merged commit dd42ed1 into feature/6554-improve-framework-architecture Sep 1, 2021
@shuse2 shuse2 deleted the 6693_fee_verify branch September 1, 2021 16:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuse2 shuse2 shuse2 approved these changes

@ishantiw ishantiw ishantiw approved these changes

Assignees

@mitsuaki-u mitsuaki-u

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitsuaki-u @shuse2 @ishantiw