Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement fee module verifyTransaction hook #6693

Closed
mitsuaki-u opened this issue Aug 25, 2021 · 0 comments
Closed

Implement fee module verifyTransaction hook #6693

mitsuaki-u opened this issue Aug 25, 2021 · 0 comments

Comments

@mitsuaki-u
Copy link
Contributor

mitsuaki-u commented Aug 25, 2021

Description

During trs verification, the following logic is applied:

minFee = MIN_FEE_PER_BYTE * size(trs) 
         + extraFee(trs.moduleID, trs.commandID)
if trs.fee < minFee:
     trs is invalid

Acceptance Criteria

  • extraFee function should be implemented
  • The verifyTransaction hook should implement the above logic.
  • Write unit tests

Additional Information

Related issue: #6691

@mitsuaki-u mitsuaki-u changed the title Implement fee module beforeTransactionExecution hook Implement fee module beforeTransactionExecution hook Aug 25, 2021
@mitsuaki-u mitsuaki-u changed the title Implement fee module beforeTransactionExecution hook Implement fee module verifyTransactionExecution hook Aug 26, 2021
@mitsuaki-u mitsuaki-u changed the title Implement fee module verifyTransactionExecution hook Implement fee module verifyTransaction hook Aug 26, 2021
@sridharmeganathan sridharmeganathan added this to the Sprint 52 milestone Aug 30, 2021
@mitsuaki-u mitsuaki-u self-assigned this Aug 31, 2021
shuse2 added a commit that referenced this issue Sep 1, 2021
Implement fee module `verifyTransaction` hook - Closes #6693
@shuse2 shuse2 closed this as completed Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants