You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update the Configuration to improve and handle multiple mode of RPC communication.
// Current Config
rpc: {mode: ipc|ws,enable: true,port: 8080,}// In Bus constructor// Problem: It starts IPC server anyways even if ipc mode is not chosenif(this.config.rpc.enable){this._ipcServer=newIPCServer({socketsDir: this.config.socketsPath.root,name: 'bus',});}if(this.config.rpc.enable&&this.config.rpc.mode==='ws'){this._wsServer=newWSServer({path: '/ws',port: config.rpc.port,host: config.rpc.host,logger: this.logger,});}
// New Config
rpc: {ipc: {path: ‘tmp/external/’},ws: {port: 8080},modes: [‘ipc’,‘ws’]}// In Bus constructorif(this.config.rpc.ipc){this._ipcServer=newIPCServer({socketsDir: this.config.socketsPath.root,name: 'bus',});}if(this.config.rpc.ws){this._wsServer=newWSServer({path: '/ws',port: config.rpc.port,host: config.rpc.host,logger: this.logger,});}
Acceptance Criteria
Config related tests should pass
Should be able to run current ws, ipc modes concurrently
Description
Update the Configuration to improve and handle multiple mode of RPC communication.
Acceptance Criteria
ws
,ipc
modes concurrentlyAdditional Information
Related #6612
The text was updated successfully, but these errors were encountered: