This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Update readme - Closes #604 #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
changed the base branch from
development
to
558-migrate_create_transaction_commands
shuse2
force-pushed
the
558-migrate_create_transaction_commands
branch
from
83b2bb2 to
e80f72b
Compare
shuse2
force-pushed
the
604-update_readme
branch
from
e83e153 to
91d7139
Compare
shuse2
force-pushed
the
558-migrate_create_transaction_commands
branch
2 times, most recently
from
1deff4c to
f82a696
Compare
shuse2
changed the base branch from
558-migrate_create_transaction_commands
to
2.0.0
shuse2
force-pushed
the
604-update_readme
branch
from
91d7139 to
8b33513
Compare
mitsuaki-u
previously requested changes
Sep 28, 2018
| ### Something else went wrong. What should I do? | ||
|
|
||
| 1. Make sure you’re on the network you intend to be on. | ||
| 1. Exit Lisk Commander (if in interactive mode) and restart. | ||
| 1. Remove the configuration file (`config.json`) located in your Lisk Commander configuration directory (`~/.lisk-commander` by default). When you restart Lisk Commander the default configuration will be recreated. | ||
| 1. Remove the configuration file (`config.json`) located in your Lisk Commander configuration directory (`~/.lisk` by default). When you restart Lisk Commander the default configuration will be recreated. |
There was a problem hiding this comment.
Path to configuration should be ~/.lisk-commander instead of ~/.lisk.
There was a problem hiding this comment.
this was actually correct, on v2.0
as https://github.com/LiskHQ/lisk-commander/blob/2.0.0/src/base.js#L22
| @@ -9,7 +9,7 @@ Lisk Commander allows you to communicate with a remote or local node and carry o | |||
|
|
|||
| ## Prerequisites | |||
|
|
|||
| Lisk Commander requires [Node.js](https://nodejs.org/) as the underlying engine for code execution. Node.js is supported on most operating systems. Follow the instructions for your operating system on the [Node.js downloads page](https://nodejs.org/en/download/). We currently require Node.js versions between 6.12 and 6.14 (inclusive). NPM is automatically installed along with Node.js. | |||
| Lisk Commander requires [Node.js](https://nodejs.org/) as the underlying engine for code execution. Node.js is supported on most operating systems. Follow the instructions for your operating system on the [Node.js downloads page](https://nodejs.org/en/download/). We currently require Node.js versions above 8.3. NPM is automatically installed along with Node.js. | |||
|
|
|||
There was a problem hiding this comment.
"8.3 and above" or "8.3 (inclusive)"?
| EXAMPLES | ||
| node:get | ||
| node:get --all | ||
| ``` |
There was a problem hiding this comment.
Add documentation and examples for --forging-status flag. Remove --all flag.
shuse2
force-pushed
the
604-update_readme
branch
from
221101d to
919642b
Compare
shuse2
force-pushed
the
604-update_readme
branch
from
919642b to
2469549
Compare
mitsuaki-u
approved these changes
Oct 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Since
v2.0dynamically change the command list, readme needed to be updated.How did I fix it?
Update the docs using autogeneration which
oclifprovides.Review checklist