Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Migrate create transaction commands - Partially closes #558 #578

Merged
merged 7 commits into from
Sep 25, 2018

Conversation

shuse2
Copy link
Contributor

@shuse2 shuse2 commented Jul 4, 2018

Description

Migration from

create transaction transfer
create transaction register second passphrase
create transaction cast votes
create transaction create multisignature account
create transaction register delegate

npm t
./bin/run transaction:create
./bin/run transaction:create:transfer
./bin/run transaction:create:secondpassphrase
./bin/run transaction:create:vote
./bin/run transaction:create:delegate
./bin/run transaction:create:multisignature

Review checklist

@shuse2 shuse2 self-assigned this Jul 4, 2018
@shuse2 shuse2 requested a review from willclarktech July 4, 2018 06:26
@shuse2 shuse2 changed the title 558 migrate create transaction commands 558 migrate create transaction commands - Partially closes #558 Jul 4, 2018
@shuse2 shuse2 changed the title 558 migrate create transaction commands - Partially closes #558 Migrate create transaction commands - Partially closes #558 Jul 4, 2018
@shuse2 shuse2 force-pushed the 558-migrate_transaction_commands branch from d6e20aa to 33e918e Compare September 5, 2018 14:41
@shuse2 shuse2 force-pushed the 558-migrate_create_transaction_commands branch from 3723670 to b857bae Compare September 5, 2018 15:05
@shuse2 shuse2 force-pushed the 558-migrate_transaction_commands branch from 33e918e to c8391e8 Compare September 11, 2018 08:57
@shuse2 shuse2 force-pushed the 558-migrate_create_transaction_commands branch 2 times, most recently from 14afeae to 83b2bb2 Compare September 12, 2018 13:14
@shuse2 shuse2 force-pushed the 558-migrate_transaction_commands branch from c8391e8 to 3a59cd1 Compare September 13, 2018 14:36
@shuse2 shuse2 force-pushed the 558-migrate_create_transaction_commands branch from 83b2bb2 to e80f72b Compare September 13, 2018 14:37
@shuse2 shuse2 changed the base branch from 558-migrate_transaction_commands to 2.0.0 September 19, 2018 13:56
@shuse2 shuse2 force-pushed the 558-migrate_create_transaction_commands branch from e80f72b to 1deff4c Compare September 20, 2018 10:36
@shuse2 shuse2 force-pushed the 558-migrate_create_transaction_commands branch from 1deff4c to f82a696 Compare September 24, 2018 08:14
src/commands/transaction/create.js Outdated Show resolved Hide resolved
src/commands/transaction/create.js Outdated Show resolved Hide resolved
src/commands/transaction/create.js Outdated Show resolved Hide resolved
src/commands/transaction/create.js Outdated Show resolved Hide resolved
src/commands/transaction/create.js Outdated Show resolved Hide resolved
src/commands/transaction/create/transfer.js Outdated Show resolved Hide resolved
src/commands/transaction/create/transfer.js Show resolved Hide resolved
src/utils/flags.js Outdated Show resolved Hide resolved
test/commands/transaction/create.test.js Outdated Show resolved Hide resolved
test/commands/transaction/create.test.js Outdated Show resolved Hide resolved
Copy link
Contributor

@willclarktech willclarktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments.

src/commands/transaction/create.js Outdated Show resolved Hide resolved
src/commands/transaction/create.js Outdated Show resolved Hide resolved
@shuse2 shuse2 merged commit 50f05a3 into 2.0.0 Sep 25, 2018
@shuse2 shuse2 deleted the 558-migrate_create_transaction_commands branch September 25, 2018 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants