Remove compiler warnings #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change in line 484 --> fallthrough - change in line 754 --> formatspecifier lu instaed d
remove fallthrough fix in code part of line 484.
|
@Links2004 |
|
@hasenradball CI/CD has been fixed, can you rebase your branch, to get the test running? |
|
@Links2004 Hi, sorry I did not get your Question. Should I rebase my branch and push again? |
|
yes, exactly. |
hasenradball
force-pushed
the
remove_Compiler_warnings
branch
from
0df45f6 to
d844fea
Compare
|
@Links2004 |
Links2004
approved these changes
Jan 5, 2024
MitchBradley
added a commit
to MitchBradley/arduinoWebSockets
that referenced
this pull request
May 2, 2024
* set minimum bufsize for base64 encode * update github actions to arduino-cli for build tests * IDE_VERSION --> CLI_VERSION * fix cli download URL * use ARDUINO_BOARD_MANAGER_ADDITIONAL_URLS env for setting board URLs * - Fix memory leak by calling delete _server in the WebSocketsServer destructor. - Improve performance by looking for match to existing socket before creating a new one * added option arguments in socket io being, for pingInterval, pongTimeout, and disconnectTimeoutCount * updated the header file for the same changes * 🐛➖ removed default values from *.cpp file * update actions/cache@v3 * fix getSocketNumber for ESP * code style * Remove compiler warnings (Links2004#854) * [Prevent unwanted Compiler Warnings]: Issue Links2004#772 * [Prevent unwanted Compiler Warnings]: Issue Links2004#772 - wrong format specifier in line 754 (Links2004#773) * [Prevent unwanted Compiler Warnings]: Issue Links2004#772 * fix build_sketch_cli result handling --------- Co-authored-by: matth-x <[email protected]> Co-authored-by: Links2004 <[email protected]> Co-authored-by: patrick <[email protected]> Co-authored-by: Shreyansh Jain <[email protected]> Co-authored-by: Lukas Runge <[email protected]> Co-authored-by: Hasenradball <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove compiler warnings due to:
changed
WebSockets.cppfilemillis().changed
WebSocketsServer.cppfileacceptinstead to deprecatedavailable