Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwanted Warnings during Compiling #772

Closed
hasenradball opened this issue Sep 14, 2022 · 2 comments
Closed

Unwanted Warnings during Compiling #772

hasenradball opened this issue Sep 14, 2022 · 2 comments

Comments

@hasenradball
Copy link
Contributor

When compiling for ESP8266 with treat al warnings as errors I got some unwantet warnings.

grafik

How should we proceed?
Schould I try to fix it?
@hasenradball
Copy link
Contributor Author

Solves Falltrough warning:

In /WebSockets/src/WebSocketsServer.cpp:484

grafik

@hasenradball
Copy link
Contributor Author

Solves printf Specifier warning:

in /WebSockets/src/WebSocketsServer.cpp:754
Just use %lu instead %d!

grafik

hasenradball added a commit to hasenradball/arduinoWebSockets that referenced this issue Sep 14, 2022
@hasenradball
[Prevent unwanted Compiler Warnings]: Issue Links2004#772
94bccd1 
- change in line 484 --> fallthrough
- change in line 754 --> formatspecifier lu instaed d
@hasenradball hasenradball mentioned this issue Sep 14, 2022
Merged
Links2004 pushed a commit that referenced this issue Jan 5, 2024
@hasenradball
Remove compiler warnings (#854)
503105a 
* [Prevent unwanted Compiler Warnings]: Issue #772
Links2004 pushed a commit that referenced this issue Jan 5, 2024
@hasenradball
[Prevent unwanted Compiler Warnings]: Issue #772 - wrong format speci…
8d193b1 
…fier in line 754 (#773)

* [Prevent unwanted Compiler Warnings]: Issue #772
MitchBradley added a commit to MitchBradley/arduinoWebSockets that referenced this issue May 2, 2024
@MitchBradley @matth-x
@Links2004 @BetterComputing @shrynshjn @lukas-runge @hasenradball
Pick up upstream changes (#3)
5713ffb 
* set minimum bufsize for base64 encode

* update github actions to arduino-cli for build tests

* IDE_VERSION --> CLI_VERSION

* fix cli download URL

* use ARDUINO_BOARD_MANAGER_ADDITIONAL_URLS env for setting board URLs

* - Fix memory leak by calling delete _server in the WebSocketsServer destructor.
- Improve performance by looking for match to existing socket before creating a new one

* added option arguments in socket io being, for pingInterval, pongTimeout, and disconnectTimeoutCount

* updated the header file for the same changes

* 🐛➖ removed default values from *.cpp file

* update actions/cache@v3

* fix getSocketNumber for ESP

* code style

* Remove compiler warnings (Links2004#854)

* [Prevent unwanted Compiler Warnings]: Issue Links2004#772

* [Prevent unwanted Compiler Warnings]: Issue Links2004#772 - wrong format specifier in line 754  (Links2004#773)

* [Prevent unwanted Compiler Warnings]: Issue Links2004#772

* fix build_sketch_cli result handling

---------

Co-authored-by: matth-x <[email protected]>
Co-authored-by: Links2004 <[email protected]>
Co-authored-by: patrick <[email protected]>
Co-authored-by: Shreyansh Jain <[email protected]>
Co-authored-by: Lukas Runge <[email protected]>
Co-authored-by: Hasenradball <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hasenradball