Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LightningFabric: Error handling for accelerator="mps" and ddp strategy pairing #16455

Merged
merged 7 commits into from
Jan 22, 2023
Merged

LightningFabric: Error handling for accelerator="mps" and ddp strategy pairing #16455

merged 7 commits into from
Jan 22, 2023

Conversation

shenoynikhil
Copy link
Contributor

@shenoynikhil shenoynikhil commented Jan 20, 2023 •
edited by awaelchli
Loading

What does this PR do?

Fixes #16148

Adds checks for lightning fabric connector similar to #16153.

Some changes (different than the version in #16153),

  • Did not include DDPSpawnStrategy DDPSpawnShardedStrategy and DDPShardedStrategy as I could not find them in lightning_fabric.strategies.
  • Added a @RunIf(mps=True) instead of mps_count_1 in the args of the function which wasn't working. (not sure about the reason)

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@shenoynikhil shenoynikhil changed the title Lightning fabric update mps LightningFabric: Error handling for accelerator="mps" and ddp strategy pairing Jan 20, 2023
@shenoynikhil shenoynikhil marked this pull request as ready for review January 20, 2023 19:14
@awaelchli awaelchli added bug Something isn't working fabric lightning.fabric.Fabric community This PR is from the community accelerator: mps Apple Silicon GPU labels Jan 21, 2023
@awaelchli awaelchli self-assigned this Jan 21, 2023
@awaelchli awaelchli added this to the v1.9.x milestone Jan 21, 2023
awaelchli
awaelchli approved these changes Jan 21, 2023
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

I ran the tests on M1 and fixed the ones that needed adjusting.

@mergify mergify bot added the ready PRs ready to be merged label Jan 22, 2023
@carmocca carmocca merged commit 81914c7 into Lightning-AI:master Jan 22, 2023
Borda pushed a commit that referenced this pull request Feb 9, 2023
@shenoynikhil @Borda
LightningFabric: Error handling for accelerator="mps" and ddp strateg…
4020032 
…y pairing (#16455)

Co-authored-by: awaelchli <[email protected]>
(cherry picked from commit 81914c7)
lantiga pushed a commit that referenced this pull request Feb 10, 2023
@shenoynikhil @lantiga
LightningFabric: Error handling for accelerator="mps" and ddp strateg…
8359fb8 
…y pairing (#16455)

Co-authored-by: awaelchli <[email protected]>
(cherry picked from commit 81914c7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees

@awaelchli awaelchli

Labels
accelerator: mps Apple Silicon GPU bug Something isn't working community This PR is from the community fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Milestone
v1.9.x
Development

Successfully merging this pull request may close these issues.

Error handling for accelerator="mps" and strategy="ddp"
3 participants
@shenoynikhil @awaelchli @carmocca