Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling for accelerator="mps" and ddp strategy pairing #16153

Merged
merged 33 commits into from
Jan 12, 2023
Merged

Error handling for accelerator="mps" and ddp strategy pairing #16153

merged 33 commits into from
Jan 12, 2023

Conversation

shenoynikhil
Copy link
Contributor

@shenoynikhil shenoynikhil commented Dec 21, 2022 •
edited
Loading

What does this PR do?

Fixes #16148

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 21, 2022
@shenoynikhil shenoynikhil marked this pull request as ready for review December 21, 2022 06:05
@mergify mergify bot added the ready PRs ready to be merged label Dec 21, 2022
@justusschock justusschock enabled auto-merge (squash) December 21, 2022 13:31
awaelchli
awaelchli reviewed Dec 21, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far!

src/pytorch_lightning/trainer/connectors/accelerator_connector.py Outdated Show resolved Hide resolved
tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py Outdated Show resolved Hide resolved
src/pytorch_lightning/trainer/connectors/accelerator_connector.py Outdated Show resolved Hide resolved
auto-merge was automatically disabled December 21, 2022 19:32

Head branch was pushed to by a user without write access

@Borda Borda requested review from awaelchli and carmocca December 24, 2022 03:28
@Borda Borda enabled auto-merge (squash) December 24, 2022 03:42
@carmocca carmocca added the community This PR is from the community label Jan 4, 2023
@carmocca carmocca added this to the v1.9 milestone Jan 4, 2023
@Borda
Copy link
Member

Borda commented Jan 10, 2023

seems like last two conversations to finish this PR :)

@awaelchli awaelchli added the accelerator: mps Apple Silicon GPU label Jan 11, 2023
@awaelchli awaelchli disabled auto-merge January 11, 2023 23:14
@awaelchli
Copy link
Contributor

Requesting re-review from either @carmocca or @justusschock given latest changes.

@Borda Borda enabled auto-merge (squash) January 12, 2023 11:45
carmocca
carmocca approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this will be done to Fabric separately

src/pytorch_lightning/trainer/connectors/accelerator_connector.py Outdated Show resolved Hide resolved
@Borda Borda merged commit 12a4e71 into Lightning-AI:master Jan 12, 2023
@shenoynikhil shenoynikhil deleted the shenoy/mps-distributed-check branch January 20, 2023 18:40
@shenoynikhil shenoynikhil mentioned this pull request Jan 20, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@justusschock justusschock justusschock approved these changes

@carmocca carmocca carmocca approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@awaelchli awaelchli

Labels
accelerator: mps Apple Silicon GPU community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

Error handling for accelerator="mps" and strategy="ddp"
5 participants
@shenoynikhil @Borda @awaelchli @carmocca @justusschock