Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated pl.loggers.base module #16120

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Remove the deprecated pl.loggers.base module #16120

merged 2 commits into from
Dec 20, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Dec 19, 2022 •
edited by github-actions bot
Loading

What does this PR do?

See title

Does your PR introduce any breaking changes? If yes, please list them.

Removes deprecated code.

cc @justusschock @awaelchli @Borda @Blaizzy

@carmocca carmocca added refactor logger Related to the Loggers breaking change Includes a breaking change labels Dec 19, 2022
@carmocca carmocca added this to the v1.9 milestone Dec 19, 2022
@carmocca carmocca self-assigned this Dec 19, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2022 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success ✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to src/pytorch_lightning/_graveyard/loggers.py, src/pytorch_lightning/loggers/__init__.py, src/pytorch_lightning/loggers/base.py, tests/tests_pytorch/deprecated_api/test_remove_1-9.py, tests/tests_pytorch/graveyard/test_loggers.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/_graveyard/loggers.py, src/pytorch_lightning/loggers/__init__.py, src/pytorch_lightning/loggers/base.py, tests/tests_pytorch/deprecated_api/test_remove_1-9.py, tests/tests_pytorch/graveyard/test_loggers.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/_graveyard/loggers.py, src/pytorch_lightning/loggers/__init__.py, src/pytorch_lightning/loggers/base.py, tests/tests_pytorch/deprecated_api/test_remove_1-9.py, tests/tests_pytorch/graveyard/test_loggers.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/_graveyard/loggers.py, src/pytorch_lightning/loggers/__init__.py, src/pytorch_lightning/loggers/base.py, tests/tests_pytorch/deprecated_api/test_remove_1-9.py, tests/tests_pytorch/graveyard/test_loggers.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to src/pytorch_lightning/_graveyard/loggers.py, src/pytorch_lightning/loggers/__init__.py, src/pytorch_lightning/loggers/base.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/pytorch_lightning/_graveyard/loggers.py, src/pytorch_lightning/loggers/__init__.py, src/pytorch_lightning/loggers/base.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, lite, 3.7) success ✅
install-pkg (ubuntu-22.04, lite, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.7) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, lite, 3.7) success ✅
install-pkg (macOS-12, lite, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.7) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, lite, 3.7) success ✅
install-pkg (windows-2022, lite, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.7) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/pytorch_lightning/_graveyard/loggers.py, src/pytorch_lightning/loggers/__init__.py, src/pytorch_lightning/loggers/base.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@carmocca carmocca enabled auto-merge (squash) December 19, 2022 22:55
@carmocca carmocca merged commit 9a98e24 into master Dec 20, 2022
@carmocca carmocca deleted the refactor/remove-depr-logger branch December 20, 2022 05:36
@mergify mergify bot added the ready PRs ready to be merged label Dec 20, 2022
carmocca added a commit that referenced this pull request Dec 20, 2022
@carmocca
Remove the deprecated pl.loggers.base module (#16120)
352e779
carmocca added a commit that referenced this pull request Dec 20, 2022
@carmocca
Remove the deprecated pl.loggers.base module (#16120)
60191fe
carmocca added a commit that referenced this pull request Dec 20, 2022
@carmocca
Remove the deprecated pl.loggers.base module (#16120)
ce1e94c
carmocca added a commit that referenced this pull request Dec 20, 2022
@carmocca
Remove the deprecated pl.loggers.base module (#16120)
0bf58fc
carmocca added a commit that referenced this pull request Dec 20, 2022
@carmocca
Remove the deprecated pl.loggers.base module (#16120)
8414ac6
nicolai86 pushed a commit that referenced this pull request Dec 20, 2022
@carmocca @nicolai86
Remove the deprecated pl.loggers.base module (#16120)
04097e6
@colobas colobas mentioned this pull request Feb 6, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
breaking change Includes a breaking change logger Related to the Loggers pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@carmocca @awaelchli @Borda