Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix use of deprecated LightningLoggerBase class #517

Merged
merged 2 commits into from
Feb 10, 2023
Merged

fix use of deprecated LightningLoggerBase class #517

merged 2 commits into from
Feb 10, 2023

Conversation

colobas
Copy link
Contributor

@colobas colobas commented Feb 6, 2023

What does this PR do?

Since pytorch_lightning version 1.9.0, LightningLoggerBase has been deprecated in favor of Logger (Related PR here). This PR makes the appropriate substitutions.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@colobas colobas force-pushed the bugfix/deprecated-lightningloggerbase branch from 950b7a2 to 599e256 Compare February 6, 2023 17:41
@ashleve ashleve changed the base branch from main to dev February 10, 2023 19:04
ashleve
ashleve approved these changes Feb 10, 2023
View reviewed changes
Copy link
Owner

@ashleve ashleve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colobas Thanks for the fix!

@ashleve ashleve merged commit d9c96b6 into ashleve:dev Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleve ashleve ashleve approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colobas @ashleve