Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch MLFlowLogger requests #15915

Merged
merged 28 commits into from
Dec 12, 2022

Conversation

schmidt-jake
Copy link
Contributor

@schmidt-jake schmidt-jake commented Dec 5, 2022

What does this PR do?

Fixes #15900.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)~
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?~
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)~

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified~ (I don't seem to have permissions for this)

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 5, 2022
@schmidt-jake schmidt-jake changed the title Batch mlflowlogger requests Batch MLFlowLogger requests Dec 6, 2022
@schmidt-jake
Copy link
Contributor Author

schmidt-jake commented Dec 6, 2022

To avoid import errors, I hid some mlflow.entities imports inside the test bodies. If someone could shine some light on how to better structure (or mock) things, I will be happy to make changes!

EDIT: thanks @awaelchli!

@schmidt-jake schmidt-jake marked this pull request as ready for review December 7, 2022 19:29
@awaelchli awaelchli added feature Is an improvement or enhancement logger: mlflow community This PR is from the community labels Dec 7, 2022
@awaelchli awaelchli added this to the v1.9 milestone Dec 7, 2022
src/pytorch_lightning/loggers/mlflow.py Outdated Show resolved Hide resolved
src/pytorch_lightning/loggers/mlflow.py Outdated Show resolved Hide resolved
src/pytorch_lightning/loggers/mlflow.py Show resolved Hide resolved
@awaelchli
Copy link
Contributor

To avoid import errors, I hid some mlflow.entities imports inside the test bodies. If someone could shine some light on how to better structure (or mock) things, I will be happy to make changes!

Your solution would work assuming the package mlflow is installed. However, the tests there should run with mocked mlflow objects without the package being installed. I pushed a commit to demonstrate how to do it.

@awaelchli awaelchli self-assigned this Dec 7, 2022
src/pytorch_lightning/loggers/mlflow.py Outdated Show resolved Hide resolved
src/pytorch_lightning/loggers/mlflow.py Show resolved Hide resolved
requirements/pytorch/loggers.info Outdated Show resolved Hide resolved
requirements/pytorch/loggers.info Outdated Show resolved Hide resolved
@schmidt-jake
Copy link
Contributor Author

@Borda @carmocca looks like tests are all passing now! Could you please review?

@carmocca carmocca enabled auto-merge (squash) December 9, 2022 00:37
@carmocca carmocca disabled auto-merge December 9, 2022 00:37
src/pytorch_lightning/loggers/mlflow.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Dec 12, 2022
@carmocca carmocca enabled auto-merge (squash) December 12, 2022 12:40
@carmocca carmocca force-pushed the batch-mlflowlogger-requests branch from 0f79699 to 183b7b4 Compare December 12, 2022 13:21
@carmocca carmocca merged commit 38acba0 into Lightning-AI:master Dec 12, 2022
@schmidt-jake schmidt-jake deleted the batch-mlflowlogger-requests branch December 12, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community feature Is an improvement or enhancement logger: mlflow pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch requests in MLFlowLogger
4 participants