Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch requests in MLFlowLogger #15900

Closed
schmidt-jake opened this issue Dec 4, 2022 · 2 comments · Fixed by #15915
Closed

Batch requests in MLFlowLogger #15900

schmidt-jake opened this issue Dec 4, 2022 · 2 comments · Fixed by #15915
Labels
feature Is an improvement or enhancement help wanted Open to be worked on

Comments

@schmidt-jake
Copy link
Contributor

schmidt-jake commented Dec 4, 2022 •
edited by github-actions bot
Loading

Proposed refactor

Update the mlflow API callsites in MLFlowLogger to use the more efficient MlflowcClient.log_batch API.

Motivation

Improve logging performance and reduce the number of API calls.

Pitch

MLFlowLogger currently executes individual API calls for every hyperparameter (in log_hyperparameters) and metric (in log_metrics) using for loops. By refactoring these two methods to use log_batch, we could reduce the number and overhead of MLFlowLogger API calls.

I'd be happy to open a PR for this.

cc @Borda
@schmidt-jake schmidt-jake added the needs triage Waiting to be triaged by maintainers label Dec 4, 2022
@Borda
Copy link
Member

Borda commented Dec 5, 2022

@schmidt-jake are you interested in implementing this feature? 🐰

@Borda Borda added feature Is an improvement or enhancement help wanted Open to be worked on and removed needs triage Waiting to be triaged by maintainers labels Dec 5, 2022
@schmidt-jake
Copy link
Contributor Author

@Borda yep, happy to do it!

@schmidt-jake schmidt-jake mentioned this issue Dec 5, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Batch MLFlowLogger requests schmidt-jake/lightning
2 participants
@Borda @schmidt-jake