Releasing/1.8.4

.azure/app-cloud-e2e.yml

@@ -27,16 +27,14 @@ pr:
       - "release/*"
   paths:
     include:
+      - ".actions/**"
       - ".azure/app-cloud-e2e.yml"
-      - "requirements/app/**"
       - "src/lightning_app/**"
-      - "tests/tests_app/**"
-      - "examples/app_*/**"  # some tests_app tests call examples files
-      - "tests/tests_app_examples/**"
+      - "requirements/app/**"
+      - "tests/tests_examples_app/**"
       - "setup.py"
-      - ".actions/**"
     exclude:
-      - "requirements/app/docs.txt"
+      - "requirements/*/docs.txt"
       - "*.md"
       - "**/*.md"
 
@@ -59,32 +57,44 @@ jobs:
       matrix:
         'App: v0_app':
           name: "v0_app"
+          dir: "public"
         'App: boring_app':
           name: "boring_app"
+          dir: "public"
         'App: template_streamlit_ui':
           name: "template_streamlit_ui"
+          dir: "public"
         'App: template_react_ui':
           name: "template_react_ui"
+          dir: "public"
         # 'App: template_jupyterlab':  # TODO: clarify where these files lives
         #   name: "template_jupyterlab"
-        'App: idle_timeout':
-          name: "idle_timeout"
-        'App: collect_failures':
-          name: "collect_failures"
-        'App: custom_work_dependencies':
-          name: "custom_work_dependencies"
         'App: installation_commands_app':
           name: "installation_commands_app"
+          dir: "public"
         'App: drive':
           name: "drive"
+          dir: "public"
         'App: payload':
           name: "payload"
+          dir: "public"
         'App: commands_and_api':
           name: "commands_and_api"
+          dir: "public"
         'App: quick_start':
           name: "quick_start"
-    timeoutInMinutes: "20"
-    cancelTimeoutInMinutes: "2"
+          dir: "public"
+        'App: idle_timeout':
+          name: "idle_timeout"
+          dir: "local"
+        'App: collect_failures':
+          name: "collect_failures"
+          dir: "local"
+        'App: custom_work_dependencies':
+          name: "custom_work_dependencies"
+          dir: "local"
+    timeoutInMinutes: "15"
+    cancelTimeoutInMinutes: "1"
     # values: https://docs.microsoft.com/en-us/azure/devops/pipelines/process/phases?view=azure-devops&tabs=yaml#workspace
     workspace:
       clean: all
@@ -124,7 +134,7 @@ jobs:
     # - bash: |
     #     rm -rf examples/app_template_jupyterlab || true
     #     git clone https://github.com/Lightning-AI/LAI-lightning-template-jupyterlab-App examples/app_template_jupyterlab
-    #     cp examples/app_template_jupyterlab/tests/test_template_jupyterlab.py tests/tests_app_examples/test_template_jupyterlab.py
+    #     cp examples/app_template_jupyterlab/tests/test_template_jupyterlab.py tests/tests_examples_app/test_template_jupyterlab.py
     #   condition: eq(variables['name'], 'template_jupyterlab')
     #   displayName: 'Clone Template Jupyter Lab Repo'
 
@@ -152,15 +162,17 @@ jobs:
     - bash: |
         mkdir -p ${VIDEO_LOCATION}
         ls -l examples/${TEST_APP_NAME}
-        ls -l tests/tests_app_examples
-        python -m pytest tests/tests_app_examples/test_${TEST_APP_NAME}.py::test_${TEST_APP_NAME}_example_cloud --timeout=1200 --capture=no -v --color=yes
+        ls -l tests/tests_examples_app/public
+        python -m pytest tests/tests_examples_app/${TEST_APP_FOLDER}/test_${TEST_APP_NAME}.py::test_${TEST_APP_NAME}_example_cloud \
+          --timeout=540 --capture=no -v --color=yes
       env:
         HEADLESS: '1'
         PACKAGE_LIGHTNING: '1'
         CLOUD: '1'
         VIDEO_LOCATION: $(video_artifact_dir)
         PR_NUMBER: $(local_id)
         TEST_APP_NAME: $(name)
+        TEST_APP_FOLDER: $(dir)
         HAR_LOCATION: './artifacts/hars'
         SLOW_MO: '50'
         #LAI_USER: $(LAI_USER)  # for STAGING
@@ -191,6 +203,7 @@ jobs:
         LIGHTNING_CLOUD_URL: $(LIGHTNING_CLOUD_URL_PROD)
         PR_NUMBER: $(local_id)
         TEST_APP_NAME: $(name)
+        TEST_APP_FOLDER: $(dir)
         # GRID_USER_ID: $(LIGHTNING_USER_ID)  # TODO: clarify the meaning
         # GRID_USER_KEY: $(LIGHTNING_API_KEY)  # TODO: clarify the meaning
         # GRID_URL: $(LIGHTNING_CLOUD_URL)

.azure/gpu-benchmark.yml

@@ -24,7 +24,7 @@ pr:
       - "tests/tests_pytorch/benchmarks/**"
       - "requirements/pytorch/**"
     exclude:
-      - "requirements/pytorch/docs.txt"
+      - "requirements/*/docs.txt"
       - "*.md"
       - "**/*.md"
 
@@ -68,14 +68,7 @@ jobs:
         pip list
       displayName: 'Image info & NVIDIA'
 
-    - bash: |
-        python .actions/assistant.py requirements_prune_pkgs --packages [horovod,bagua,colossalai] --req_files [requirements/pytorch/strategies.txt]
-
-        PYTORCH_VERSION=$(python -c "import torch; print(torch.__version__.split('+')[0])")
-        python ./requirements/pytorch/adjust-versions.py requirements/pytorch/base.txt ${PYTORCH_VERSION}
-      displayName: 'Adjust dependencies'
-
-    - bash: pip install -e .[dev,strategies,examples] --find-links ${TORCH_URL}
+    - bash: pip install -e .[dev] --find-links ${TORCH_URL}
       env:
         PACKAGE_NAME: "pytorch"
         FREEZE_REQUIREMENTS: "1"

.azure/gpu-tests-lite.yml

@@ -20,6 +20,7 @@ pr:
       - "release/*"
   paths:
     include:
+      - ".actions/**"
       - ".azure/gpu-tests-lite.yml"
       - "examples/lite/**"
       - "examples/run_lite_examples.sh"
@@ -29,9 +30,8 @@ pr:
       - "src/lightning_lite/**"
       - "tests/tests_lite/**"
       - "setup.cfg"  # includes pytest config
-      - ".actions/**"
     exclude:
-      - "requirements/lite/docs.txt"
+      - "requirements/*/docs.txt"
       - "*.md"
       - "**/*.md"
 

.azure/gpu-tests-pytorch.yml

@@ -20,6 +20,7 @@ pr:
       - "release/*"
   paths:
     include:
+      - ".actions/**"
       - ".azure/gpu-tests-pytorch.yml"
       - "examples/run_ddp_examples.sh"
       - "examples/convert_from_pt_to_pl/**"
@@ -36,9 +37,8 @@ pr:
       - "setup.cfg"  # includes pytest config
       - "requirements/lite/**"
       - "src/lightning_lite/**"
-      - ".actions/**"
     exclude:
-      - "requirements/**/docs.txt"
+      - "requirements/*/docs.txt"
       - "*.md"
       - "**/*.md"
 

.azure/hpu-tests.yml

@@ -17,6 +17,7 @@ pr:
       - "release/*"
   paths:
     include:
+      - ".actions/**"
       - ".azure/hpu-tests.yml"
       - "examples/pl_hpu/mnist_sample.py"
       - "requirements/lite/**"
@@ -25,9 +26,8 @@ pr:
       - "src/pytorch_lightning/**"
       - "tests/tests_pytorch/**"
       - "setup.cfg"  # includes pytest config
-      - ".actions/**"
     exclude:
-      - "requirements/**/docs.txt"
+      - "requirements/*/docs.txt"
       - "*.md"
       - "**/*.md"
 

.azure/ipu-tests.yml

@@ -15,16 +15,16 @@ pr:
       - "release/*"
   paths:
     include:
+      - ".actions/**"
       - ".azure/ipu-tests.yml"
       - "requirements/lite/**"
       - "src/lightning_lite/**"
       - "requirements/pytorch/**"
       - "src/pytorch_lightning/**"
       - "tests/tests_pytorch/**"
       - "setup.cfg"  # includes pytest config
-      - ".actions/**"
     exclude:
-      - "requirements/**/docs.txt"
+      - "requirements/*/docs.txt"
       - "*.md"
       - "**/*.md"
 

.github/CODEOWNERS

@@ -45,7 +45,7 @@
 # Lightning App
 /src/lightning_app                          @tchaton @lantiga @awaelchli @hhsecond @ethanwharris
 /tests/tests_app                            @tchaton @lantiga @awaelchli @hhsecond @ethanwharris
-/tests/tests_app_examples                   @tchaton @lantiga @awaelchli @hhsecond @ethanwharris
+/tests/tests_examples_app                   @tchaton @lantiga @awaelchli @hhsecond @ethanwharris
 /examples/app_*                             @tchaton @lantiga @awaelchli @hhsecond @ethanwharris
 
 /.github/CODEOWNERS                  @williamfalcon

.github/actions/pkg-publish/action.yml

@@ -5,9 +5,14 @@ inputs:
   pkg-pattern:
     description: what file pattern is searched in folder, so for example `*_app*`
     required: true
+  pypi-test-token:
+    description: login token for PyPI
+    default: ''
+    required: false
   pypi-token:
     description: login token for PyPI
-    required: true
+    default: ''
+    required: false
 
 runs:
   using: "composite"
@@ -20,16 +25,19 @@ runs:
     shell: bash
 
   # We do this, since failures on test.pypi aren't that bad
-  #- name: Publish to Test PyPI
-  #  uses: pypa/[email protected]
-  #  with:
-  #    user: __token__
-  #    password: ${{ secrets.test_pypi_token_lai }}
-  #    repository_url: https://test.pypi.org/legacy/
-  #    verbose: true
+  - name: Publish to Test PyPI
+    uses: pypa/[email protected]
+    if: inputs.pypi-test-token != ''
+    with:
+      user: __token__
+      password: ${{ secrets.test_pypi_token_lai }}
+      repository_url: https://test.pypi.org/legacy/
+      packages_dir: pypi/
+      verbose: true
 
   - name: Publish distribution 📦 to PyPI
     uses: pypa/[email protected]
+    if: inputs.pypi-token != ''
     with:
       user: __token__
       password: ${{ inputs.pypi-token }}