Releasing/1.8.4 #15870
Merged
Releasing/1.8.4 #15870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
carmocca,
tchaton,
lantiga,
awaelchli,
hhsecond,
ethanwharris,
justusschock,
williamFalcon and
akihironitta
as code owners
* rename _examples dir * refactor * clean * path * add inits * skip * e2e * azure * e2e * rev * unify single depth for ignore docs req. * group (cherry picked from commit 59fa320)
(cherry picked from commit 51bb845)
split examples and pytests (cherry picked from commit 952b64b)
(cherry picked from commit 3a99a25)
(cherry picked from commit 9e43604)
(cherry picked from commit 0a12731)
…Flow in the cloud (#15800) * update * update * update * update * update * update * update * update * update * update * update * update * update * update * updte * update * update * update * update * update * update * update * update * update * update * update * Update src/lightning_app/CHANGELOG.md Co-authored-by: Ethan Harris <[email protected]> * Update src/lightning_app/utilities/port.py Co-authored-by: Ethan Harris <[email protected]> * Update src/lightning_app/utilities/port.py Co-authored-by: Ethan Harris <[email protected]> * Update src/lightning_app/utilities/port.py Co-authored-by: Ethan Harris <[email protected]> * Update src/lightning_app/utilities/port.py Co-authored-by: Ethan Harris <[email protected]> * Update src/lightning_app/utilities/port.py Co-authored-by: Ethan Harris <[email protected]> * Update src/lightning_app/utilities/port.py Co-authored-by: Ethan Harris <[email protected]> Co-authored-by: Ethan Harris <[email protected]> (cherry picked from commit 8ca6dfe)
…quirements (#15420) Update lightning-utilities requirement in /requirements Updates the requirements on [lightning-utilities](https://github.com/Lightning-AI/utilities) to permit the latest version. - [Release notes](https://github.com/Lightning-AI/utilities/releases) - [Changelog](https://github.com/Lightning-AI/utilities/blob/main/CHANGELOG.md) - [Commits](Lightning-AI/utilities@v0.3.0...v0.4.0) --- updated-dependencies: - dependency-name: lightning-utilities dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit e150d08)
Co-authored-by: Carlos Mocholí <[email protected]> (cherry picked from commit 8ee889b)
Borda
force-pushed
the
releasing/1.8.4
branch
from
67ebb3d to
f844e19
Compare
(cherry picked from commit f171657)
(cherry picked from commit 1e56b75)
(cherry picked from commit cca3432)
Co-authored-by: Carlos Mocholí <[email protected]> (cherry picked from commit 6a2a83a)
* prune dependency for benchmarks * drop (cherry picked from commit 993bd67)
* fixing legacy checkpoints * Apply suggestions from code review Co-authored-by: Akihiro Nitta <[email protected]> (cherry picked from commit fee52f9)
(cherry picked from commit f4fcad3)
* waiting * builds (cherry picked from commit a86584d)
* drop name column from cluster list * change create cluster to accept id as well * rename validator * remove cluster name from logs * fix merge with master * more merge with master issues (cherry picked from commit a82be2f)
|
seem the failing PL-cpu test are green but the CI/check ends-up red 🦦 |
* initial work on deleting apps * after PR review * delete CLI working * restructred to make tests easier * revert manifest changes * added changelog, fix mypy issue * updates * Update src/lightning_app/cli/cmd_apps.py Co-authored-by: Jirka Borovec <[email protected]> * Update src/lightning_app/cli/lightning_cli_delete.py Co-authored-by: Jirka Borovec <[email protected]> * Update src/lightning_app/cli/lightning_cli_delete.py Co-authored-by: Jirka Borovec <[email protected]> * Update src/lightning_app/cli/lightning_cli_delete.py Co-authored-by: Sherin Thomas <[email protected]> * Update src/lightning_app/cli/lightning_cli_delete.py Co-authored-by: Sherin Thomas <[email protected]> * import typing * adding tests * finished adding tests * addressed code review comments * fix mypy error * make mypy happy * make mypy happy * make mypy happy * make mypy happy * fix windows cli Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Sherin Thomas <[email protected]> (cherry picked from commit b4d99e3)
* Add `is_headless` when dispatching in the cloud * Bump cloud version * Add tests * Dont open app page for headless apps locally * Refactor * Update CHANGELOG.md * Support dynamic UIs at runtime * Comments * Fix * Updates * Fixes and cleanup * Fix tests * Dont open view page for headless apps * Fix test, resolve URL the right way * Remove launch * Clean * Cleanup tests * Fixes * Updates * Add test * Increase app cloud tests timeout * Increase timeout * Wait for running * Revert timeouts * Clean * Dont update if it hasnt changed * Increase timeout (cherry picked from commit 32cf1fa)
(cherry picked from commit ab022ac)
for more information, see https://pre-commit.ci
* Direct support for compiled models * Update test * Update src/pytorch_lightning/core/module.py Co-authored-by: Ethan Harris <[email protected]> Co-authored-by: Ethan Harris <[email protected]> (cherry picked from commit 2992002)
* update * param * Apply suggestions from code review (cherry picked from commit 77006a2)
(cherry picked from commit 852089e)
|
@tchaton see like all e2e tests are failing after picking your last commit, mind having a look? |
(cherry picked from commit d2a8fbf)
(cherry picked from commit 6f54a82)
* Enable back inference mode support with hpu * Remove unused * Update document link and address comment Signed-off-by: Jerome <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 6aaac8b)
* Exlucde __pycache__ in setuptools * Add load balancer example * wip * Update example * rename * remove prints * _LoadBalancer -> LoadBalancer * AutoScaler(work) * change var name * remove locust * Update docs * include autoscaler in api ref * docs typo * docs typo * docs typo * docs typo * remove unused loadtest * remove unused device_type * clean up * clean up * clean up * Add docstring * type * env vars to args * expose an API for users to override to customise autoscaling logic * update example * comment * udpate var name * fix scale mechanism and clean up * Update exampl * ignore mypy * Add test file * . * update impl and update tests * Update changlog * . * revert docs * update test * update state to keep calling 'flow.run()' Co-authored-by: Aniket Maurya <[email protected]> * Add aiohttp to base requirements * Update docs Co-authored-by: Luca Antiga <[email protected]> * Use deserializer utility * fake trigger * wip: protect /system/* with basic auth * read password at runtime * Change env var name * import torch as optional * Don't overcreate works * simplify imports * Update example * aiohttp * Add work_args work_kwargs * More docs * remove FIXME * Apply Jirka's suggestions Co-authored-by: Jirka Borovec <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * clean example device * add comment on init threshold value * bad merge * nit: logging format * {in,out}put_schema -> {in,out}put_type * lowercase * docs on seconds * process_time -> processing_time * Dont modify work state from flow * Update tests * worker_url -> endpoint * fix exampl * Fix default scale logic * Fix default scale logic * Fix num_pending_works * Update num_pending_works * Fix bug creating too many works * Remove up/downscale_threshold args * Update example * Add typing * Fix example in docstring * Fix default scale logic * Update src/lightning_app/components/auto_scaler.py Co-authored-by: Noha Alon <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * rename method * rename locvar * Add todo * docs ci * docs ci * asdfafsdasdf pls docs * Apply suggestions from code review Co-authored-by: Ethan Harris <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * . * doc * Update src/lightning_app/components/auto_scaler.py Co-authored-by: Noha Alon <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks" This reverts commit 24983a0. * Revert "Update src/lightning_app/components/auto_scaler.py" This reverts commit 56ea78b. * Remove redefinition * Remove load balancer run blocker * raise RuntimeError * remove has_sent * lower the default timeout_batching from 10 to 1 * remove debug * update the default timeout_batching * . * tighten condition * fix endpoint * typo in runtimeerror cond * async lock update severs * add a test * {in,out}put_type typing * Update examples/app_server_with_auto_scaler/app.py Co-authored-by: Jirka Borovec <[email protected]> * Update .actions/setup_tools.py Co-authored-by: Aniket Maurya <[email protected]> Co-authored-by: Luca Antiga <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Noha Alon <[email protected]> Co-authored-by: Ethan Harris <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]> Co-authored-by: thomas chaton <[email protected]> (cherry picked from commit 64b19fb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TBD
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda