Integrate lightning_utilities==0.4.2 #15817

carmocca · 2022-11-25T14:18:40Z

What does this PR do?

Fixes Lightning-AI/utilities#57

Does your PR introduce any breaking changes? If yes, please list them.

None

cc @Borda

github-actions · 2022-11-25T14:19:24Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to requirements/lite/base.txt, requirements/pytorch/base.txt, tests/tests_pytorch/callbacks/test_callbacks.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/deprecated_api/__init__.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/graveyard/test_legacy_import_unpickler.py, tests/tests_pytorch/helpers/utils.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/loops/test_training_loop_flow_scalar.py, tests/tests_pytorch/models/test_hparams.py, tests/tests_pytorch/models/test_restore.py, tests/tests_pytorch/test_cli.py, tests/tests_pytorch/trainer/connectors/test_data_connector.py, tests/tests_pytorch/trainer/flags/test_min_max_epochs.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py, tests/tests_pytorch/tuner/test_lr_finder.py, tests/tests_pytorch/tuner/test_scale_batch_size.py, tests/tests_pytorch/utilities/test_data.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to requirements/pytorch/base.txt, tests/tests_pytorch/callbacks/test_callbacks.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/deprecated_api/__init__.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/graveyard/test_legacy_import_unpickler.py, tests/tests_pytorch/helpers/utils.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/loops/test_training_loop_flow_scalar.py, tests/tests_pytorch/models/test_hparams.py, tests/tests_pytorch/models/test_restore.py, tests/tests_pytorch/test_cli.py, tests/tests_pytorch/trainer/connectors/test_data_connector.py, tests/tests_pytorch/trainer/flags/test_min_max_epochs.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py, tests/tests_pytorch/tuner/test_lr_finder.py, tests/tests_pytorch/tuner/test_scale_batch_size.py, tests/tests_pytorch/utilities/test_data.py, requirements/lite/base.txt.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
pytorch-lightning.Benchmark	success	✅

These checks are required after the changes to requirements/pytorch/base.txt.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to requirements/lite/base.txt, requirements/pytorch/base.txt, tests/tests_pytorch/callbacks/test_callbacks.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/deprecated_api/__init__.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/graveyard/test_legacy_import_unpickler.py, tests/tests_pytorch/helpers/utils.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/loops/test_training_loop_flow_scalar.py, tests/tests_pytorch/models/test_hparams.py, tests/tests_pytorch/models/test_restore.py, tests/tests_pytorch/test_cli.py, tests/tests_pytorch/trainer/connectors/test_data_connector.py, tests/tests_pytorch/trainer/flags/test_min_max_epochs.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py, tests/tests_pytorch/tuner/test_lr_finder.py, tests/tests_pytorch/tuner/test_scale_batch_size.py, tests/tests_pytorch/utilities/test_data.py.

🟢 pytorch_lightning: Azure IPU

Check ID	Status
pytorch-lightning (IPUs)	success	✅

These checks are required after the changes to requirements/lite/base.txt, requirements/pytorch/base.txt, tests/tests_pytorch/callbacks/test_callbacks.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/deprecated_api/__init__.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/graveyard/test_legacy_import_unpickler.py, tests/tests_pytorch/helpers/utils.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/loops/test_training_loop_flow_scalar.py, tests/tests_pytorch/models/test_hparams.py, tests/tests_pytorch/models/test_restore.py, tests/tests_pytorch/test_cli.py, tests/tests_pytorch/trainer/connectors/test_data_connector.py, tests/tests_pytorch/trainer/flags/test_min_max_epochs.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py, tests/tests_pytorch/tuner/test_lr_finder.py, tests/tests_pytorch/tuner/test_scale_batch_size.py, tests/tests_pytorch/utilities/test_data.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to requirements/pytorch/base.txt.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.9, 1.10, 11.3.1)	success	✅
build-cuda (3.9, 1.11, 11.3.1)	success	✅
build-cuda (3.9, 1.12, 11.6.1)	success	✅
build-cuda (3.9, 1.13, 11.6.1)	success	✅
build-hpu (1.5.0, 1.11.0)	success	✅
build-ipu (3.9, 1.10)	success	✅
build-NGC	success	✅
build-pl (3.9, 1.10, 11.3.1)	success	✅
build-pl (3.9, 1.11, 11.3.1)	success	✅
build-pl (3.9, 1.12, 11.6.1)	success	✅
build-pl (3.9, 1.13, 11.6.1)	success	✅
build-xla (3.7, 1.12)	success	✅

These checks are required after the changes to requirements/pytorch/base.txt, requirements/lite/base.txt.

🟢 lightning_lite: CPU workflow

Check ID	Status
lite-cpu (macOS-11, lite, 3.8, 1.11)	success	✅
lite-cpu (macOS-11, lite, 3.9, 1.12)	success	✅
lite-cpu (macOS-11, lite, 3.10, 1.13)	success	✅
lite-cpu (macOS-11, lite, 3.7, 1.10, oldest)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.8, 1.10)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.9, 1.11)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.12)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.13)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.7, 1.10, oldest)	success	✅
lite-cpu (windows-2022, lite, 3.9, 1.11)	success	✅
lite-cpu (windows-2022, lite, 3.10, 1.12)	success	✅
lite-cpu (windows-2022, lite, 3.10, 1.13)	success	✅
lite-cpu (windows-2022, lite, 3.7, 1.10, oldest)	success	✅
lite-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
lite-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
lite-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to requirements/lite/base.txt, tests/tests_lite/helpers/utils.py, tests/tests_lite/plugins/environments/test_slurm.py, tests/tests_lite/test_lite.py.

🟢 lightning_lite: Azure GPU

Check ID	Status
lightning-lite (GPUs)	success	✅

These checks are required after the changes to requirements/lite/base.txt, tests/tests_lite/helpers/utils.py, tests/tests_lite/plugins/environments/test_slurm.py, tests/tests_lite/test_lite.py.

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, app, 3.8, latest)	success	✅
app-pytest (macOS-11, app, 3.8, oldest)	success	✅
app-pytest (macOS-11, lightning, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅
app-pytest (windows-2022, app, 3.8, oldest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅

These checks are required after the changes to tests/tests_app/components/multi_node/test_base.py, tests/tests_app/components/multi_node/test_lite.py, tests/tests_app/components/multi_node/test_trainer.py, tests/tests_app/helpers/utils.py, requirements/app/base.txt, requirements/app/components.txt, requirements/app/devel.txt, requirements/app/examples.txt.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (macOS-11, app, 3.9, oldest)	success	✅
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, oldest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅

These checks are required after the changes to tests/tests_examples_app/public/test_multi_node.py, requirements/app/base.txt, requirements/app/components.txt, requirements/app/devel.txt, requirements/app/examples.txt.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to requirements/app/base.txt, requirements/app/components.txt, requirements/app/devel.txt, requirements/app/examples.txt, tests/tests_examples_app/public/test_multi_node.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to requirements/app/base.txt, requirements/app/components.txt, requirements/app/devel.txt, requirements/app/examples.txt.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/app/base.txt, requirements/app/components.txt, requirements/app/devel.txt, requirements/app/examples.txt, requirements/lite/base.txt, requirements/pytorch/base.txt.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, lite, 3.7)	success	✅
install-pkg (ubuntu-22.04, lite, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.7)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, lite, 3.7)	success	✅
install-pkg (macOS-12, lite, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.7)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, lite, 3.7)	success	✅
install-pkg (windows-2022, lite, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.7)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to requirements/app/base.txt, requirements/app/components.txt, requirements/app/devel.txt, requirements/app/examples.txt, requirements/lite/base.txt, requirements/pytorch/base.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

carmocca · 2022-11-27T10:53:20Z

This is blocked by #15786

carmocca · 2022-12-01T19:49:20Z

Now blocked by #15454. Will try to remove this circular dependency in this PR

Co-authored-by: Jirka Borovec <[email protected]>

Integrate lightning_utilities==0.4.2

cb92a9c

carmocca added the tests label Nov 25, 2022

carmocca added this to the v1.9 milestone Nov 25, 2022

carmocca self-assigned this Nov 25, 2022

carmocca requested review from tchaton, lantiga, awaelchli, hhsecond, ethanwharris, justusschock, williamFalcon and Borda as code owners November 25, 2022 14:18

carmocca added 2 commits November 25, 2022 19:40

Missed 1

aa4878b

Fixes

76b5627

awaelchli approved these changes Nov 26, 2022

View reviewed changes

Borda approved these changes Nov 26, 2022

View reviewed changes

mergify bot added the ready PRs ready to be merged label Nov 26, 2022

carmocca marked this pull request as draft November 27, 2022 10:54

mergify bot removed the ready PRs ready to be merged label Nov 27, 2022

Merge branch 'master' into ci/utilities-0.4.2

8724df1

carmocca marked this pull request as ready for review December 1, 2022 19:41

mergify bot added the ready PRs ready to be merged label Dec 1, 2022

carmocca force-pushed the ci/utilities-0.4.2 branch from 7fa0139 to 8651b2c Compare December 1, 2022 19:51

Use master

5e301ca

carmocca force-pushed the ci/utilities-0.4.2 branch from 8651b2c to 5e301ca Compare December 1, 2022 19:54

carmocca added 2 commits December 1, 2022 21:04

Try removing. Shouldn't be necessary

2e96bf4

Multinode example requires torch

992f7f7

mergify bot added has conflicts and removed ready PRs ready to be merged labels Dec 8, 2022

Merge branch 'master' into ci/utilities-0.4.2

6db3df6

mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Dec 8, 2022

Borda and others added 6 commits December 12, 2022 14:57

Merge branch 'master' into ci/utilities-0.4.2

08e75aa

Fix import

12ef35c

Merge branch 'master' into ci/utilities-0.4.2

3ab98b6

Merge branch 'master' into ci/utilities-0.4.2

e3da88e

One more

1cdffcd

Add component requirements

ae0bb5c

carmocca enabled auto-merge (squash) December 13, 2022 11:59

carmocca merged commit 53ceb15 into master Dec 13, 2022

carmocca deleted the ci/utilities-0.4.2 branch December 13, 2022 13:13

awaelchli pushed a commit that referenced this pull request Dec 15, 2022

Integrate lightning_utilities==0.4.2 (#15817)

8aa96d0

Co-authored-by: Jirka Borovec <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate lightning_utilities==0.4.2 #15817

Integrate lightning_utilities==0.4.2 #15817

carmocca commented Nov 25, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Nov 25, 2022 •

edited

Loading

carmocca commented Nov 27, 2022

carmocca commented Dec 1, 2022

Integrate lightning_utilities==0.4.2 #15817

Integrate lightning_utilities==0.4.2 #15817

Conversation

carmocca commented Nov 25, 2022 • edited by github-actions bot Loading

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

github-actions bot commented Nov 25, 2022 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

carmocca commented Nov 27, 2022

carmocca commented Dec 1, 2022

carmocca commented Nov 25, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Nov 25, 2022 •

edited

Loading