Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyclic dependency: lightning and lightning-api-access #15786

Closed
cdeepali opened this issue Nov 23, 2022 · 2 comments · Fixed by #15844
Closed

cyclic dependency: lightning and lightning-api-access #15786

cdeepali opened this issue Nov 23, 2022 · 2 comments · Fixed by #15844
Assignees
Labels
app (removed) Generic label for Lightning App package bug Something isn't working priority: 0 High priority task
Milestone

Comments

@cdeepali
Copy link

cdeepali commented Nov 23, 2022

Bug description

There is a cyclic dependency between lightning and lightning-api-access packages:

lightning requires lightning-api-access
and
lightning-api-access requires lightning

$ pip show lightning-api-access
Name: lightning-api-access
Version: 0.0.1
Summary: ⚡ API Access UI ⚡
Home-page: https://github.com/Lightning-AI/LAI-API-Access-UI-Component
Author: Lightning et al.
Author-email: [email protected]
License:
Location: /opt/conda/lib/python3.9/site-packages
Requires: lightning
Required-by: lightning


$ pip show lightning
Name: lightning
Version: 1.8.3
Summary: Use Lightning Apps to build everything from production-ready, multi-cloud ML systems to simple research demos.
Home-page: https://github.com/Lightning-AI/lightning
Author: Lightning AI et al.
Author-email: [email protected]
License: Apache-2.0
Location: /opt/conda/lib/python3.9/site-packages
Requires: arrow, beautifulsoup4, click, croniter, deepdiff, fsspec, fsspec, inquirer, lightning-api-access, lightning-cloud, lightning-utilities, numpy, packaging, packaging, psutil, PyYAML, starsessions, tensorboardX, torch, torchmetrics, tqdm, traitlets, typing-extensions
Required-by: lightning-api-access

cc @tchaton

@cdeepali cdeepali added the needs triage Waiting to be triaged by maintainers label Nov 23, 2022
@awaelchli
Copy link
Contributor

awaelchli commented Nov 25, 2022

@tchaton @hhsecond It looks like we added a component repo as a base requirement in Lightning. This shouldn't be there since it's optional and not required to run apps. Let's remove it?

cc @Borda

@awaelchli awaelchli added bug Something isn't working priority: 0 High priority task and removed needs triage Waiting to be triaged by maintainers labels Nov 25, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Nov 25, 2022
@awaelchli awaelchli added the app (removed) Generic label for Lightning App package label Nov 25, 2022
@Borda
Copy link
Member

Borda commented Nov 25, 2022

@tchaton @hhsecond It looks like we added a component repo as a base requirement in Lightning. This shouldn't be there since it's optional and not required to run apps. Let's remove it?

yeah, that was exactly what I was hunting in #15776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package bug Something isn't working priority: 0 High priority task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants