Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix PL docs build on readthedocs.org (#15511)" #15565

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Nov 7, 2022

This reverts commit e818e82.

What does this PR do?

Reverts the commit since it didn't work and the issue was resolved by #15493.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @akihironitta

@akihironitta akihironitta self-assigned this Nov 7, 2022
@akihironitta akihironitta added the ci Continuous Integration label Nov 7, 2022
@akihironitta akihironitta added this to the v1.9 milestone Nov 7, 2022
@akihironitta akihironitta enabled auto-merge (squash) November 7, 2022 03:23
@akihironitta akihironitta merged commit 8d19297 into master Nov 7, 2022
@akihironitta akihironitta deleted the ci/revert-readthedocs branch November 7, 2022 10:10
@mergify mergify bot added the ready PRs ready to be merged label Nov 7, 2022
Borda pushed a commit that referenced this pull request Nov 8, 2022
lexierule pushed a commit that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants