Do not modify PACKAGE_NAME on install #15493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
williamFalcon,
Borda,
akihironitta and
otaj
as code owners
carmocca
force-pushed
the
ci/avoid-writing-pkg-name
branch
from
75cd063 to
3531b0d
Compare
|
The tricky part is that the package selection needs to be included in the build package, so we can instead of rewrite setup.py and write it to an extra file, but it still need to be dumped somewhere and distributed with sdist/wheel |
Borda
reviewed
Nov 3, 2022
Borda
reviewed
Nov 3, 2022
Borda
reviewed
Nov 3, 2022
carmocca
force-pushed
the
ci/avoid-writing-pkg-name
branch
from
ffba74d to
e03646f
Compare
carmocca
requested review from
tchaton,
awaelchli,
kaushikb11 and
rohitgr7
as code owners
carmocca
force-pushed
the
ci/avoid-writing-pkg-name
branch
2 times, most recently
from
c2903e5 to
fdff3a8
Compare
carmocca
force-pushed
the
ci/avoid-writing-pkg-name
branch
from
fdff3a8 to
52c2b5a
Compare
mergify
bot
added
ready
akihironitta
approved these changes
Nov 4, 2022
|
There's been a small change to the checkgroup config: f81ae59 so this will need force-merge. CI was green the commit before: https://github.com/Lightning-AI/lightning/actions/runs/3393882442/jobs/5643540143 |
Borda
approved these changes
Nov 4, 2022
mergify
bot
added
ready
This reverts commit 8340b85.
Borda
pushed a commit
that referenced
this pull request
Nov 5, 2022
* Do not modify PACKAGE_NAME on install * Fix ci pkg action * Required * Typos * Apply suggestions from code review * Undo defaults * Cleanup * Implement idea * Fuck * Apps mock fix * Fix app-pytest with PKG_NAME=app * Justus suggestion * Debug Windows * Update setup.py Co-authored-by: Adrian Wälchli <[email protected]> * Revert "Debug Windows" This reverts commit 9fe3ba3. * SSH action * Crazy bug * Revert "SSH action" This reverts commit 5061e8e. * Package import step * Avoid env conflict * Debug * Whitespace * Try removing existing lite build * This should be redundant now * Add back env now that source-lit is gone * Remove download artifact * checkgroup * TODOs suggested by Jirka * _ * Revert "_". These are local variables, do not need protected This reverts commit 8340b85. Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> (cherry picked from commit f392180)
7 tasks
lexierule
pushed a commit
that referenced
this pull request
Nov 10, 2022
* Do not modify PACKAGE_NAME on install * Fix ci pkg action * Required * Typos * Apply suggestions from code review * Undo defaults * Cleanup * Implement idea * Fuck * Apps mock fix * Fix app-pytest with PKG_NAME=app * Justus suggestion * Debug Windows * Update setup.py Co-authored-by: Adrian Wälchli <[email protected]> * Revert "Debug Windows" This reverts commit 9fe3ba3. * SSH action * Crazy bug * Revert "SSH action" This reverts commit 5061e8e. * Package import step * Avoid env conflict * Debug * Whitespace * Try removing existing lite build * This should be redundant now * Add back env now that source-lit is gone * Remove download artifact * checkgroup * TODOs suggested by Jirka * _ * Revert "_". These are local variables, do not need protected This reverts commit 8340b85. Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> (cherry picked from commit f392180)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title.
lightningis no longer installed whenPACKAGE_NAME=lite|app|pytorchis installed.Part of #15474
Fixes #15489 by reverting most of #14517
Does your PR introduce any breaking changes? If yes, please list them.
None
cc @carmocca @akihironitta @Borda