Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a check to validate that wrapped FSDP models are used while initializing optimizers #15301

Merged
merged 20 commits into from
Nov 8, 2022
Merged

Added a check to validate that wrapped FSDP models are used while initializing optimizers #15301

merged 20 commits into from
Nov 8, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Oct 25, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Closes #14900

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@rohitgr7 rohitgr7 added the strategy: fsdp Fully Sharded Data Parallel label Oct 25, 2022
@rohitgr7 rohitgr7 added this to the v1.8 milestone Oct 25, 2022
@rohitgr7 rohitgr7 self-assigned this Oct 25, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 25, 2022
@rohitgr7 rohitgr7 requested a review from awaelchli October 26, 2022 18:32
@awaelchli awaelchli modified the milestones: v1.8, v1.9 Oct 27, 2022
@mergify mergify bot removed the has conflicts label Oct 31, 2022
@rohitgr7 rohitgr7 requested a review from otaj as a code owner October 31, 2022 21:31
@rohitgr7 rohitgr7 changed the title Add info about optimizer initialization for native fsdp Added a check to validate that wrapped FSDP models are used while initializing optimizers Oct 31, 2022
@awaelchli
Copy link
Contributor

I think the meta package or something in the CI using it is broken. Changes in lightning_lite do not get reflected in the PL installation, as we can see here.

@awaelchli awaelchli mentioned this pull request Nov 1, 2022
Closed
11 tasks
@awaelchli awaelchli mentioned this pull request Nov 2, 2022
Merged
11 tasks
@awaelchli
Copy link
Contributor

Blocked by #15469

@rohitgr7 rohitgr7 requested a review from carmocca November 3, 2022 12:19
carmocca
carmocca reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a docs blocker which I believe is caused by #15489

@awaelchli awaelchli mentioned this pull request Nov 4, 2022
Merged
@awaelchli awaelchli enabled auto-merge (squash) November 4, 2022 20:58
@awaelchli awaelchli mentioned this pull request Nov 4, 2022
Closed
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Nov 5, 2022
akihironitta
akihironitta approved these changes Nov 7, 2022
View reviewed changes
src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Nov 7, 2022
@awaelchli awaelchli merged commit 0886e63 into master Nov 8, 2022
@awaelchli awaelchli deleted the doc/fsdp_wrapper branch November 8, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@akihironitta akihironitta akihironitta approved these changes

@Borda Borda Borda approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@otaj otaj Awaiting requested review from otaj

Assignees

@awaelchli awaelchli

Labels
pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: fsdp Fully Sharded Data Parallel
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

Tensors not on the same device when using FSDP auto-wrapping
5 participants
@rohitgr7 @awaelchli @Borda @carmocca @akihironitta