Grep for potential errors in standalone tests #15341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
awaelchli,
rohitgr7,
otaj,
justusschock,
Borda and
akihironitta
as code owners
|
Sorry for the review notification. Accidentally marked it as non-draft |
|
@awaelchli If you can help, this uncovered a failing Lite test: https://dev.azure.com/Lightning-AI/lightning/_build/results?buildId=112478&view=logs&j=8a08b103-7f3c-5f4b-1889-6a795acbb007&t=a889fbb9-184d-53b2-4806-a80daee53cd7&l=325: |
|
@carmocca was able to reproduce and fix locally. Should be resolved now. Let me know if there are any other failures like this one popping up. |
carmocca
force-pushed
the
tests/grep-errors-standalone
branch
from
225678a to
2888007
Compare
akihironitta
approved these changes
Nov 4, 2022
awaelchli
approved these changes
Nov 4, 2022
otaj
approved these changes
Nov 4, 2022
justusschock
approved these changes
Nov 4, 2022
|
TPUs are failing, but there's an issue with the logs. Blocked by #15533 |
Borda
pushed a commit
that referenced
this pull request
Nov 8, 2022
Co-authored-by: awaelchli <[email protected]> (cherry picked from commit 12d6e44)
lexierule
pushed a commit
that referenced
this pull request
Nov 10, 2022
Co-authored-by: awaelchli <[email protected]> (cherry picked from commit 12d6e44)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title
Fixes #12474
Does your PR introduce any breaking changes? If yes, please list them.
None
cc @Borda