-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hydra changes to lightning-lite #14950
Merged
awaelchli
merged 11 commits into
Lightning-AI:master
from
Atharva-Phatak:hydra-changes-lite
Sep 30, 2022
Merged
Hydra changes to lightning-lite #14950
awaelchli
merged 11 commits into
Lightning-AI:master
from
Atharva-Phatak:hydra-changes-lite
Sep 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atharva-Phatak
requested review from
awaelchli,
carmocca,
justusschock and
kaushikb11
as code owners
September 29, 2022 18:48
awaelchli
added
3rd party
Related to a 3rd-party
fabric
lightning.fabric.Fabric
feature
Is an improvement or enhancement
labels
Sep 29, 2022
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #14950 +/- ##
=========================================
+ Coverage 84% 86% +2%
=========================================
Files 395 276 -119
Lines 28850 21100 -7750
=========================================
- Hits 24206 18052 -6154
+ Misses 4644 3048 -1596 |
awaelchli
reviewed
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! One minor comment.
And I will take a look at the tests later on.
…k/lightning into hydra-changes-lite
for more information, see https://pre-commit.ci
carmocca
approved these changes
Sep 29, 2022
awaelchli
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the same changes #11617 to lightning lite launcher. This PR addresses the issue #14799 .
Fixes #14799
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃