Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Hydra improvements to Lite #14799

Closed
awaelchli opened this issue Sep 20, 2022 · 7 comments · Fixed by #14950
Closed

Bring Hydra improvements to Lite #14799

awaelchli opened this issue Sep 20, 2022 · 7 comments · Fixed by #14950
Assignees
Labels
fabric lightning.fabric.Fabric good first issue Good for newcomers refactor
Milestone

Comments

@awaelchli
Copy link
Contributor

awaelchli commented Sep 20, 2022

Proposed refactor

Apply/share changes in #11617 with the Lite implementation.

Motivation

Since both are using the same launcher, the improvements should be integrated for both.

Pitch

Move the _hydra_subprocess_cmd functions to lightning_lite.strategies.lauchers.subprocess, and share the implementation in PL.

Additional context

#11617 was developed in parallel to standalone Lite efforts, so we didn't have time to adjust.


If you enjoy Lightning, check out our other projects! ⚡

  • Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

  • Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

  • Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

  • Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

  • Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging PyTorch Lightning, Transformers, and Hydra.

@awaelchli awaelchli added needs triage Waiting to be triaged by maintainers refactor fabric lightning.fabric.Fabric good first issue Good for newcomers and removed needs triage Waiting to be triaged by maintainers labels Sep 20, 2022
@awaelchli awaelchli added this to the pl:future milestone Sep 20, 2022
@Atharva-Phatak
Copy link
Contributor

Hi @awaelchli, I am interested in this, is this up for the taking? Also could provide some additional in terms of whats expected in the PR ?

@awaelchli
Copy link
Contributor Author

@Atharva-Phatak Yes, sure. Once #11617 is merged feel free to work on it. The PR should just integrate the same changes in this file here: https://github.com/Lightning-AI/lightning/blob/master/src/lightning_lite/strategies/launchers/subprocess_script.py

@Atharva-Phatak
Copy link
Contributor

@awaelchli Thanks for the update. I will work on it once #11617 has merged.

@carmocca
Copy link
Contributor

It is merged now 🎉

@Atharva-Phatak
Copy link
Contributor

Thanks for letting me know. I will get started.

@Atharva-Phatak
Copy link
Contributor

Hi, quick question, I was seeing the #11617 looks like it added Hydra support for multirun. I believe most changes were made to the launcher (https://github.com/Lightning-AI/lightning/blob/45ca78167efaa98f5e78ca73d79d4e71946db253/src/pytorch_lightning/strategies/launchers/subprocess_script.py) and for this issue, I have to apply the same changes to lightning Lite right ?

@awaelchli
Copy link
Contributor Author

@Atharva-Phatak Yes, my idea is that the new functions (e.g. _hydra_subprocess_cmd) can just me moved to Lite, then imported in PL to share the code. Then all is left call the function in the Lite version of the launcher as well, as it was done in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric good first issue Good for newcomers refactor
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants