Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix ignored paths #13733

Merged
merged 1 commit into from
Jul 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci-app_cloud_e2e_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ name: cloud-testing

on: # Trigger the workflow on push or pull request, but only for the master branch
push:
branches:
- "master"
branches: [master, "release/*"]
pull_request:
branches: [master, "release/*"]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref }}
Expand Down
9 changes: 2 additions & 7 deletions .github/workflows/ci-app_examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,9 @@ name: Test App - examples
# see: https://help.github.com/en/actions/reference/events-that-trigger-workflows
on: # Trigger the workflow on push or pull request, but only for the master branch
push:
branches:
- "master"
branches: [master, "release/*"]
pull_request:
paths:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop this as several examples uses PL

- "src/lightning_app/**"
- "tests/tests_app_examples/**"
- "requirements/app/**"
- "setup.py"
branches: [master, "release/*"]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref }}
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/ci-app_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ name: Test App
# see: https://help.github.com/en/actions/reference/events-that-trigger-workflows
on: # Trigger the workflow on push or pull request, but only for the master branch
push:
branches:
- "master"
branches: [master, "release/*"]
pull_request:
paths:
- "src/lightning_app/**"
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/ci_pkg-install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on: # Trigger the workflow on push or pull request, but only for the master bra
branches: [master, "release/*"]
pull_request:
branches: [master, "release/*"]
paths-ignore:
- "src/lightning_app/**" # todo: implement job skip

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref }}
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/cicd-pytorch_dockers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@ on:
paths:
- "dockers/**"
- "!dockers/README.md"
- "requirements/*"
- "requirements/**"
- "requirements.txt"
- "environment.yml"
- ".github/workflows/*docker*.yml"
- ".github/workflows/events-nightly.yml"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was dropped in #13576

- "setup.py"
schedule:
- cron: "0 0 * * *" # at the end of every day
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ jobs:
repo-token: ${{ secrets.GITHUB_TOKEN }}

publish-package:
# fixme: each package needs to be signed with own auth token
runs-on: ubuntu-20.04
needs: build-meta-pkg
if: startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release'
Expand Down