Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix ignored paths #13733

Merged
merged 1 commit into from
Jul 19, 2022
Merged

CI: fix ignored paths #13733

merged 1 commit into from
Jul 19, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 19, 2022 •
edited
Loading

What does this PR do?

turned out we were after adding CI for App were ignoring falsely many cases

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @tchaton @rohitgr7 @carmocca @akihironitta @Borda

@Borda Borda added priority: 0 High priority task ci Continuous Integration labels Jul 19, 2022
@Borda Borda enabled auto-merge (squash) July 19, 2022 11:41
Borda
Borda commented Jul 19, 2022
View reviewed changes
.github/workflows/ci-app_examples.yml
pull_request:
paths:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop this as several examples uses PL

Borda
Borda commented Jul 19, 2022
View reviewed changes
.github/workflows/cicd-pytorch_dockers.yml
- "requirements.txt"
- "environment.yml"
- ".github/workflows/*docker*.yml"
- ".github/workflows/events-nightly.yml"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was dropped in #13576

@mergify mergify bot added the ready PRs ready to be merged label Jul 19, 2022
@mergify mergify bot requested a review from a team July 19, 2022 11:59
@lexierule lexierule disabled auto-merge July 19, 2022 17:25
@lexierule lexierule merged commit 6cbd9d7 into master Jul 19, 2022
@lexierule lexierule deleted the ci/paths branch July 19, 2022 17:25
Borda added a commit that referenced this pull request Jul 29, 2022
@Borda
CI: fix ignored paths (#13733)
67275c7 
(cherry picked from commit 6cbd9d7)
lexierule pushed a commit that referenced this pull request Aug 1, 2022
@Borda @lexierule
CI: fix ignored paths (#13733)
4a21ab8 
(cherry picked from commit 6cbd9d7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

@carmocca carmocca carmocca approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees
No one assigned
Labels
ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Borda @carmocca @akihironitta @lexierule