fix path separator in neptune logger

[monty5811]

What does this PR do?

Fixes #10602

The neptune logger fails on windows as the expected path in _get_full_model_name assumes that the separator is /.
This PR uses os.sep instead.

Fixes: n/a

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

[akihironitta]

Seems like the tests failed on Windows.

FAILED tests/loggers/test_neptune.py::TestNeptuneLogger::test_after_save_checkpoint
FAILED tests/loggers/test_neptune.py::TestNeptuneLoggerUtils::test__get_full_model_name

[Raalsky]

Seems like the tests failed on Windows.

FAILED tests/loggers/test_neptune.py::TestNeptuneLogger::test_after_save_checkpoint
FAILED tests/loggers/test_neptune.py::TestNeptuneLoggerUtils::test__get_full_model_name

It seems there are strict Posix paths in mocks/assertions 😉. You should update them accordingly with os.path.join etc.

[Raalsky]

I think it could be closed as we already took a care of separator and tests in #10369 .

[awaelchli]

Closing as it was already included in the linked PR. Thanks @monty5811 for taking a stab at this.