Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neptune Logger assumes unix-style filepath for model checkpoint #10602

Closed
seba-eng opened this issue Nov 18, 2021 · 2 comments · Fixed by #10369
Closed

Neptune Logger assumes unix-style filepath for model checkpoint #10602

seba-eng opened this issue Nov 18, 2021 · 2 comments · Fixed by #10369
Labels
bug Something isn't working logger: neptune
Milestone

Comments

@seba-eng
Copy link

seba-eng commented Nov 18, 2021

The Neptune Logger can automatically upload model checkpoints if the callback is used. It generates an "expected_model_path" for that. This path has hard-coded a '/' at the end (see here), which can cause problems on Windows systems because the actual path has (or can have) a backslash at this position. A simple fix would be to use os.path.sep insteat of '/'.

cc @justusschock @awaelchli @akihironitta

@seba-eng
Copy link
Author

never mind, there is already a pull request (#10500) for this problem

@awaelchli awaelchli reopened this Nov 19, 2021
@awaelchli
Copy link
Contributor

Let's use this issue then to link with the PR (which had no bug report attached).
I interpret that you are reporting a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logger: neptune
Projects
None yet
2 participants