Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the chunk size by adding header size #395

Merged
merged 4 commits into from
Oct 12, 2024
Merged

Conversation

tchaton
Copy link
Collaborator

@tchaton tchaton commented Oct 11, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

This adds the chunk header to get the proper file size.

Fixes #393

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 78%. Comparing base (b9aa903) to head (124ee8f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #395   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        34     34           
  Lines      5037   5040    +3     
===================================
+ Hits       3941   3944    +3     
  Misses     1096   1096           

@tchaton tchaton merged commit 3f47b5e into main Oct 12, 2024
29 checks passed
@tchaton tchaton deleted the fix_filesize_bytes branch October 12, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing / Reading Bug involving writer chunk_bytes information
2 participants