Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the chunk size by adding header size #394

Closed
wants to merge 1 commit into from

Conversation

dangthatsright
Copy link
Contributor

@dangthatsright dangthatsright commented Oct 10, 2024

What does this PR do?

Fixes #393

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

thanks @tchaton for the help!

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72%. Comparing base (b9aa903) to head (af5db07).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b9aa903) and HEAD (af5db07). Click for more details.

HEAD has 12 uploads less than BASE
Flag BASE (b9aa903) HEAD (af5db07)
unittests 6 2
3.10 3 1
3.9 3 1
ubuntu-22.04 2 0
macos-13 2 0
Additional details and impacted files
@@         Coverage Diff          @@
##           main   #394    +/-   ##
====================================
- Coverage    78%    72%    -7%     
====================================
  Files        34     34            
  Lines      5037   5039     +2     
====================================
- Hits       3941   3607   -334     
- Misses     1096   1432   +336     

@bhimrazy
Copy link
Collaborator

Closing this PR as issue #393 has been resolved by #395.

Thank you @dangthatsright for taking the time to raise this issue and work on it.
We encourage you to test it with the latest updates from the main branch,
and we welcome any feedback on how it goes.

@bhimrazy bhimrazy closed this Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing / Reading Bug involving writer chunk_bytes information
2 participants