Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axial_tht: Also generate THT resistor packages #119

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

ubruhin
Copy link
Member

@ubruhin ubruhin commented Oct 2, 2023

There are currently three THT resistor packages in the base library which were originally imported from Eagle, cause several library editor warnings and do not have 3D models although for (THT-)hobbyists these are probably the most used packages.

Since these packages are similar to the already generated THT diodes, I extended the script to also generate these three resistor packages, including 3D models:

image

(I think the models would look better once we implement shadow effects in the viewer).

The footprints now look pretty different to the old ones:
image image

The pad shape is now square resp. circular instead of octagon, identical to the THT diodes. Actually the silkscreen drawing was pretty nice before, but I'm not sure if it is worth the effort to make the generator conditionally creating different silkscreen for resistors. In other EDA libraries, resistors are just a rectangle as well...

The packages still have several footprints for different pitches, even a few more than before.

@ubruhin ubruhin force-pushed the tht-resistors branch 4 times, most recently from 0e75a8c to 470c3ab Compare October 4, 2023 21:34
@ubruhin ubruhin added enhancement New feature or request ready for review labels Oct 5, 2023
@ubruhin ubruhin marked this pull request as ready for review October 5, 2023 20:07
@ubruhin
Copy link
Member Author

ubruhin commented Oct 5, 2023

Should be ready now, base library PR opened: LibrePCB-Libraries/LibrePCB_Base.lplib#125

@ubruhin ubruhin merged commit 6246bc6 into master Oct 16, 2023
8 checks passed
@ubruhin ubruhin deleted the tht-resistors branch October 16, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready for review
Development

Successfully merging this pull request may close these issues.

1 participant