Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework pkg/dev of THT resistors #125

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Rework pkg/dev of THT resistors #125

merged 2 commits into from
Oct 16, 2023

Conversation

ubruhin
Copy link
Contributor

@ubruhin ubruhin commented Oct 5, 2023

SUMMARY
  • Rework THT resistor packages, now generated by librepcb-parts-generator, which brings several improvements:
    • Complete & consistent documentation/legend polygons identical to the THT diode packages.
    • Pad shapes & sizes identical to the THT diode packages.
    • Add package outline & courtyard polygons.
    • Add more footprint variants for more different pitches.
    • Add 3D models.
    • More informative description.
  • Improve metadata of THT resistor devices
    • More consistent name with other devices
    • More informative description
    • Approve "no parts" message
DATASHEETS / REFERENCES

Parts generator PR (see there for screenshots): LibrePCB/librepcb-parts-generator#119

OPEN QUESTIONS / UNRESOLVED ISSUES

None

CHECKLIST
  • I have read and followed the library conventions¹.
  • For packages, I followed IPC7351C (see details in library conventions).
  • For modified elements, I bumped their version number².
  • I already used the new library elements in a design and verified their correctness (optional).
  • I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
  • I agree to publish all my changes under the CC0 Public Domain License³, allowing everyone to use and modify the content without any restrictions.

¹ Library Conventions: https://docs.librepcb.org/#libraryconventions
² Minor version bump if only metadata was modified (e.g. "0.1" -> "0.1.1"), major version bump if functional changes were made (e.g. "0.1" -> "0.2")
³ CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0

Now generated by librepcb-parts-generator, which brings several
improvements:

- Complete & consistent documentation/legend polygons identical to the
  THT diode packages.
- Pad shapes & sizes identical to the THT diode packages.
- Add package outline & courtyard polygons.
- Add more footprint variants for more different pitches.
- Add 3D models.
- More informative description.
- More consistent name with other devices
- More informative description
- Approve "no parts" message
@ubruhin ubruhin added ready for review Waiting for review by maintainers. enhancement Improving an existing library element. labels Oct 5, 2023
@ubruhin ubruhin merged commit 954f918 into master Oct 16, 2023
2 checks passed
@ubruhin ubruhin deleted the rework-tht-resistors branch October 16, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing library element. ready for review Waiting for review by maintainers.
Development

Successfully merging this pull request may close these issues.

1 participant