-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meson: update to 0.45 #2607
meson: update to 0.45 #2607
Conversation
InuSasha
commented
Mar 21, 2018
- generate cross-file per package, needed since Fix cross environment pollution. mesonbuild/meson#1807 was merged. build-flags can used like in cmake and configure, now.
I have no objection to the function being added, but I'm not entirely comfortable with the relative path for MESON_CONF, and creating the file every time seems unnecessary when the per-target conf worked fine (is there an advantage to writing it every time?) |
|
OK, then my only real concern is the relative path, as I think it should be absolute - I don't care where, so long as it's absolute. :) If necessary, don't set |
- generate cross-file per package, needed since mesonbuild/meson#1807 to use changed build-flags
squashed commit and clean build is done (RPi2) |
One final suggestion - have you thought about using a Here document for https://github.com/InuSasha/LibreELEC.tv/blob/d38cadaf8c08c497189d9878fa93ed7e1a5c81f5/config/functions#L160-L177 ? The following patch converts it into a Here document: http://ix.io/11BI (I've tested it, and it produces identical output to the individual |
@MilhouseVH we can change this. I like this solution more, too. |
Ok, I can merge this and push the Here doc change in a separate PR. |