-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stripping changes #2
Conversation
fixes corrupt stack on arm
If it's the same as #4661 then my comments remain the same - my only concern is that it appears to bloat addons, not sure if this is intentional or can be improved upon? Otherwise I'm totally OK with this, thanks. |
Good to go 👍 we can figure out stripping add-ons as we go |
I would not call that bloat. it will make debugging in binary addons much, much easier including line numbers and so on. whatever you dont want to have debug syms shipped - just do
at the end of addon(). would work for any OE addon. EDIT: you should probably keep kodi binary addons unstripped, but strip everything else (official and unofficial repos). however, for most trivial addons shipped in repo, size does not matter. |
True, it's only adds a few MBs to the addons (although relatively speaking it can result in some add-ons increasing by 50% in size). However if it proves useful then it shouldn't be an issue, and nobody has complained so far (well, apart from me - maybe consider it more of an observation than complaint!) |
merge 20160707 from Master
stripping changes
1) Python3 needs the util-linux:host dependency otherwise uuid support will leak over from the build host during a clean build, only to use util-linux:host for uuid support during a subsequent rebuild (which fails, because of #2) 2) util-linux:host needs -fPIC as this is what Python3 requires (clean builds work because of #1...) 3) Remove toolchain from util-linux:host to avoid a circular toolchain reference now that Python3 is also part of toolchain (via meson)
see the discussion at OpenELEC/OpenELEC.tv#4661
@MilhouseVH is this ok with you?