Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stripping changes #2

Merged
merged 8 commits into from
Mar 14, 2016
Merged

stripping changes #2

merged 8 commits into from
Mar 14, 2016

Conversation

lrusak
Copy link
Member

@lrusak lrusak commented Mar 13, 2016

see the discussion at OpenELEC/OpenELEC.tv#4661

@MilhouseVH is this ok with you?

@MilhouseVH
Copy link
Contributor

If it's the same as #4661 then my comments remain the same - my only concern is that it appears to bloat addons, not sure if this is intentional or can be improved upon? Otherwise I'm totally OK with this, thanks.

@lrusak
Copy link
Member Author

lrusak commented Mar 14, 2016

Good to go 👍 we can figure out stripping add-ons as we go

MilhouseVH added a commit that referenced this pull request Mar 14, 2016
@MilhouseVH MilhouseVH merged commit d8f6577 into LibreELEC:master Mar 14, 2016
@stefansaraev
Copy link
Contributor

I would not call that bloat. it will make debugging in binary addons much, much easier including line numbers and so on. whatever you dont want to have debug syms shipped - just do

debug_strip $ADDON_BUILD/$PKG_ADDON_ID/ 

at the end of addon(). would work for any OE addon.

EDIT: you should probably keep kodi binary addons unstripped, but strip everything else (official and unofficial repos). however, for most trivial addons shipped in repo, size does not matter.

@MilhouseVH
Copy link
Contributor

True, it's only adds a few MBs to the addons (although relatively speaking it can result in some add-ons increasing by 50% in size). However if it proves useful then it shouldn't be an issue, and nobody has complained so far (well, apart from me - maybe consider it more of an observation than complaint!)

CvH pushed a commit that referenced this pull request Sep 13, 2018
1) Python3 needs the util-linux:host dependency otherwise uuid support will
   leak over from the build host during a clean build, only to use util-linux:host
   for uuid support during a subsequent rebuild (which fails, because of #2)

2) util-linux:host needs -fPIC as this is what Python3 requires (clean builds
   work because of #1...)

3) Remove toolchain from util-linux:host to avoid a circular toolchain
   reference now that Python3 is also part of toolchain (via meson)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants