This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
reachdown
instead of:subleveldown/leveldown.js
Lines 183 to 189 in 992353b
Two notable differences:
reachdown
does not doif (typeof db.down === 'function') return db.down(type)
. That's OK, we didn't add adown()
method anywhere nor did we advertise this ability.subleveldown
now doesn't just get the innermost db (db.db.db..
). Instead, it traverses down untildb
is not alevelup
,deferred-leveldown
orencoding-down
instance. This means, if there are additional layers (e.g.encrypt-down
,cachedown
)subleveldown
stops there, not necessarily at the "storage layer".Canary-tested against
cabal-core
(which uses the oldmemdb
, I'll be sending them a PR to switch tolevel-mem
).This PR fails on node 6 because of a new test on
encrypt-down
which uses ES6. I'll see if I can make that test dependency-free by mocking anabstract-leveldown
.