-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type property to levelup and abstract-leveldown implementations #82
Labels
enhancement
New feature or request
Comments
Awesome name |
vweevers
added a commit
to Level/level-test
that referenced
this issue
Sep 14, 2019
vweevers
added a commit
to Level/subleveldown
that referenced
this issue
Sep 15, 2019
vweevers
added a commit
to Level/subleveldown
that referenced
this issue
Sep 17, 2019
vweevers
added a commit
to Level/levelup
that referenced
this issue
Sep 22, 2019
vweevers
added a commit
to Level/levelup
that referenced
this issue
Sep 30, 2019
vweevers
added a commit
to Level/levelup
that referenced
this issue
Sep 30, 2019
* Add manifest * Add type property for reachdown (Level/community#82)
vweevers
added a commit
to Level/encoding-down
that referenced
this issue
Oct 1, 2019
Closing because the remaining items are external ( |
vweevers
added a commit
to Level/packager
that referenced
this issue
Oct 13, 2019
vweevers
added a commit
to Level/level
that referenced
this issue
Oct 13, 2019
This was referenced Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A continuation of Level/subleveldown#34. cc @ralphtheninja
Background
Modules like
subleveldown
andmultileveldown
have to peel off layers (levelup
,deferred-leveldown
and/orencoding-down
) from an input db to get to the inner db, which they then rewrap with those same layers.That process ain't pretty, so I wrote
reachdown
to hide that ugliness. It currently has to feature-detectdeferred-leveldown
andencoding-down
, and this may clash with anotherabstract-leveldown
implementation at some point. To counter that, we can add atype
property across the board:Note: with that in place, the unwrapping (or even merely the fact that we have to unwrap) still isn't very clean, but IMO it's acceptable as a medium-term solution because there's a plan to merge
level(up)
functionality intoabstract-leveldown
(#58) which ultimately removes the need to unwrap.Tasks
Add
type
levelup
deferred-leveldown
encoding-down
subleveldown
(already had it)multileveldown
Release: not ourslevel-js
(not needed now)leveldown
(not needed now)memdown
(not needed now)rocksdb
Use
reachdown
utilitysubleveldown
(reachdown
itself was adapted from code insubleveldown
)multileveldown
Release: not ourslevel-bench
level-test
(in its tests)The text was updated successfully, but these errors were encountered: