Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mai/feat 310 add make pick button functionali #376
Mai/feat 310 add make pick button functionali #376
Changes from 30 commits
8e23935
a4118e7
2374f91
db2aca9
cfd953b
2975439
c40febb
ec05b49
21ceca0
1ddaffe
511fc4f
bb98c59
b2655b0
39184a8
7dd7a40
6d542e7
ca0c821
56db007
5bac0ef
211fb5e
e92213d
f962596
38a0fa3
4abbda0
3a0a2f4
06aa565
4ada0da
6800fae
c9e85d6
ede4210
76d2799
32b056f
8b41c9d
6964c13
fbb86a1
6813b62
f6e93a0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, looking at this more, this should be optional. When a user hasn't selected a team yet, there won't be a team logo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some testing with this: required vs optional.
Even if we make it required, no teamLogo pops up so I'd like to leave as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it optional. When implementing this component, the IDE will force the user to put something in for teamLogo prop. Which, it is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. Thanks for letting me know and I reverted it back to optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a test that checked the linkUrl. It's a required prop so it should be prioritized to be tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in a linkUrl Test