Mai/feat 310 add make pick button functionali #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ical/gridiron-survivor into shashi/entries-page
|
Gridiron Survivor Application
Project name: Gridiron Survivor Application
Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vmaineng
changed the base branch from
shashi/entries-page
to
shashi/add-entry-logic
…/feat-310-add-make-pick-button-functionali
…or into mai/feat-310-add-make-pick-button-functionali
shashilo
requested changes
Jul 22, 2024
| teamLogo: string; |
There was a problem hiding this comment.
Make it optional. When implementing this component, the IDE will force the user to put something in for teamLogo prop. Which, it is not needed.
vazquezea96
approved these changes
Jul 23, 2024
shashilo
requested changes
Jul 26, 2024
| * @returns {React.JSX.Element} - A div element that contains the user's entry information | ||
| */ | ||
| const LeagueEntries = ({ | ||
| entryName, | ||
| linkUrl, | ||
| isEliminated = false, | ||
| isPickSet = false, | ||
| teamLogo = '', |
There was a problem hiding this comment.
It's still empty.
Suggested change
| teamLogo = '', | |
| teamLogo, |
shashilo
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #310