Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created custom button variants #132
Created custom button variants #132
Changes from all commits
fef4b0c
882c6c4
c1e7f36
9b1944a
25f45be
de6874b
a3cb2f5
7873597
23cda40
0beb9fe
ad0b008
1c60d12
13d3223
150c876
c69a735
1ed9d61
d5b02f1
64241c1
3360617
6084d63
2b72175
8c3f927
fccff99
86e4dfc
fd4f662
5200f39
98d9f94
fb831e0
042d0b2
8710a45
e3bf2aa
98f4bb7
8243d70
ae7159d
0ea6cfb
bc71101
65f6c55
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is ESLINT being added to this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it is because I've been doing
git pull origin develop
every day I continued working on this? Other than that, I've only usedpnpm install
when I originally created the branch.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are pulling in the latest from
develop
it would not cause an update. This is saying that your changes differ from what's indevelop
today. You may have a local setting for npm or pnpm that forces an update when you install. In @chris-nowicki's PR, there was no usage of this package. Do we need it? https://github.com/LetsGetTechnical/gridiron-survivor/pull/123/files