Created custom button variants #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryandotfurrer
requested review from
shashilo,
mhchen and
jayrobin
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
choir241
requested changes
Apr 13, 2024
Buh, it was still running when I last checked and didn't see it failed. I'll have to look into why. |
4 tasks
|
@ryandotfurrer |
shashilo
requested changes
Apr 15, 2024
|
@ryandotfurrer please adjust the Storybook story to reflect and show these variants as well. This is the way @jasinn will review design implementation. Also, add unit test for these components to ensure the variants are showing the correct styles. We should look into adding visual tests with Storybook 8 as well. |
I will make these updates (and your above-mentioned ones) by EoD 4/16/24. |
shashilo
requested changes
Apr 24, 2024
package.json
Outdated
| @@ -47,15 +47,13 @@ | |||
| "@types/node": "20.3.1", | |||
| "@types/react": "18.2.8", | |||
| "@types/react-dom": "18.2.5", | |||
| "@typescript-eslint/eslint-plugin": "^7.6.0", | |||
There was a problem hiding this comment.
Why are these packages being removed? I'm pretty sure this was not intentional.
stories/About/Developer Guide.mdx
Outdated
| @@ -32,3 +32,24 @@ import client from '../assets/client_component.png'; | |||
| <code>git push --set-upstream origin richard/user-picks-page</code> | |||
|
|
|||
| Subsequent pushes will now go to your remote upstream branch. | |||
|
|
|||
| ## Connecting to <del>Supabase</del> | |||
There was a problem hiding this comment.
I think we need to talk about merge conflicts. :D This is not the first time Supabase came back into your PR.
Remove unnecessary space in Button log out component. Co-authored-by: Shashi Lo <[email protected]>
shashilo
approved these changes
Apr 25, 2024
ryandotfurrer
added a commit
that referenced
this pull request
Apr 30, 2024
Closes #155 # Created nav component  https://github.com/LetsGetTechnical/gridiron-survivor/assets/40150036/0e143fbb-a8f7-45b9-9465-0983c3dfbc10 ## Todo - [x] Add hamburger icon ~~- [ ] Add logic to show sign out only if user is signed in (?)~~ Not needed for MVP - [x] Integrate `Button.tsx` component from #132 and use in place of standard `<button>` element --------- Co-authored-by: Shashi Lo <[email protected]>
Clue355
pushed a commit
that referenced
this pull request
Apr 30, 2024
Closes #155 # Created nav component  https://github.com/LetsGetTechnical/gridiron-survivor/assets/40150036/0e143fbb-a8f7-45b9-9465-0983c3dfbc10 ## Todo - [x] Add hamburger icon ~~- [ ] Add logic to show sign out only if user is signed in (?)~~ Not needed for MVP - [x] Integrate `Button.tsx` component from #132 and use in place of standard `<button>` element --------- Co-authored-by: Shashi Lo <[email protected]>
Clue355
pushed a commit
that referenced
this pull request
May 1, 2024
Closes issue #124 ## Change Description(s) -Edited Button component to customize to our colors - Commented out the initial "default" and "outline" variants and made my own. - [Our design](https://www.figma.com/file/jJXt7OmmwSvHLpkFa8zEDh/Gridiron-Survivor-App?type=design&node-id=1-153&mode=design&t=yuGQC9u2T3Dxgmvn-0) currently only uses one type of button, but I thought it wise to at least add one other variant. -  - I also edited the base button component, not just our variants, to be the full-width of their container as no part of our design has a button that is not as wide as the parent container. ## Finished Results Below is a screenshot of their buttons. I placed them inside a div with a border and some padding so you could see that they are the full-width of the parent container (minus the padding).  --------- Co-authored-by: Shashi Lo <[email protected]>
Clue355
pushed a commit
that referenced
this pull request
May 1, 2024
Closes #155 # Created nav component  https://github.com/LetsGetTechnical/gridiron-survivor/assets/40150036/0e143fbb-a8f7-45b9-9465-0983c3dfbc10 ## Todo - [x] Add hamburger icon ~~- [ ] Add logic to show sign out only if user is signed in (?)~~ Not needed for MVP - [x] Integrate `Button.tsx` component from #132 and use in place of standard `<button>` element --------- Co-authored-by: Shashi Lo <[email protected]>
Clue355
pushed a commit
that referenced
this pull request
May 1, 2024
Closes #155  https://github.com/LetsGetTechnical/gridiron-survivor/assets/40150036/0e143fbb-a8f7-45b9-9465-0983c3dfbc10 - [x] Add hamburger icon ~~- [ ] Add logic to show sign out only if user is signed in (?)~~ Not needed for MVP - [x] Integrate `Button.tsx` component from #132 and use in place of standard `<button>` element --------- Co-authored-by: Shashi Lo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #124
Change Description(s)
-Edited Button component to customize to our colors
Finished Results
Below is a screenshot of their buttons. I placed them inside a div with a border and some padding so you could see that they are the full-width of the parent container (minus the padding).