LIVE-2003 - Feature - Pass urls through regex to replace template by locale

[nparigi-ledger]

❓ Context

• Impacted projects: ledger-live-mobile
• Linked resource(s): https://ledgerhq.atlassian.net/jira/software/c/projects/LIVE/boards/463?modal=detail&selectedIssue=LIVE-2003&sprint=994&assignee=6102d4f20b454a0068cad0d6

Substitute url strings by getter function with regex replacing template {locale} by current locale

Ex: ledger.com/{locale}/ become ledger.com/fr/

✅ Checklist

• Test coverage: Did you write any tests to cover the changes introduced by this pull request?
• Atomic delivery: Is this pull request standalone? In order words, does it depend on nothing else?
• Breaking changes: Does this pull request contain breaking changes of any kind? If so, please explain why.

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

Note: Migrated from LedgerHQ/ledger-live-mobile#2451

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
ledger-live-github-bot	✅ Ready (Inspect)	Visit Preview	May 18, 2022 at 3:02PM (UTC)
live-common-tools	✅ Ready (Inspect)	Visit Preview	May 18, 2022 at 3:02PM (UTC)

2 Ignored Deployments

Name	Status	Preview	Updated
native-ui-storybook	⬜️ Ignored (Inspect)		May 18, 2022 at 3:02PM (UTC)
react-ui-storybook	⬜️ Ignored (Inspect)		May 18, 2022 at 3:02PM (UTC)

[changeset-bot]

⚠️ No Changeset found

Latest commit: ee54bc2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

@valpinkman

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

[gre]

can we avoid adding more ts-ignore in our codebase? 🙏 not sure what the error was but we may have to find a better algorithm.

Also, I'm not a huge fan of the usage of get() here. It will not help performance to have a lot of these kind of code.
I totally understand that i was meant not to be breaking change tho. But, we are making urls dynamic, so in a way it's a new feature, it is ok to make it explicit 🤔 I guess that means changing all parts where we get that URL, but I feel it's for the better good.

There are probably different ways to do this, one way could be a function getURL("key", lang). We can also cache per lang / refresh a map per lang. anything that could try to avoid doing this at runtime 🙏

[github-actions]

There as been no activity on this PR for the last 14 days. Please consider closing this PR.