Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

LIVE-2003 - Feature - Pass urls through regex to replace template by locale #2451

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nparigi-ledger
Copy link
Contributor

Substitute url strings by getter function with regex replacing template {locale} by current locale

Ex: ledger.com/{locale}/ become ledger.com/fr/

Type

Feature

Context

https://ledgerhq.atlassian.net/jira/software/c/projects/LIVE/boards/463?modal=detail&selectedIssue=LIVE-2003&sprint=994&assignee=6102d4f20b454a0068cad0d6

Parts of the app affected / Test plan

Config urls

@nparigi-ledger nparigi-ledger requested a review from a team as a code owner April 26, 2022 11:05
@github-actions
Copy link

Thanks for your contribution.
To be groomed for next release, you need to:

  • pass the CI
  • if needed, run /generate-screenshots
  • have a dev review
  • have a QA review

Why /generate-screenshots ?

If your PR contains UI related changes,
it might be necessary to regenerate screenshots.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants