Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix egui feature compilation error #421

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

tim-blackbird
Copy link
Contributor

Fixes a compile error with the egui feature enabled when the ui or block_ui_interactions features are disabled.

@WesleyClements
Copy link
Contributor

I've looked into the tests failing a bit and it seems that changing the mouse_motion to a Vec is preventing app.send_input from doing anything. Specifically, the MouseMotion is being created but not propagated back into update_action_state because self.mouse_motion.push is a mutation on a copy of the data.

@WesleyClements
Copy link
Contributor

I addressed the failing tests in #424 but do make sure that the changes I made make sense

@alice-i-cecile
Copy link
Contributor

You're both great: thank you. I'm currently sick, but I'm looking to sit down with LWIM later this week and fix stuff up.

@alice-i-cecile alice-i-cecile added this to the 0.12 milestone Dec 12, 2023
@alice-i-cecile alice-i-cecile merged commit 4c9aaf5 into Leafwing-Studios:main Dec 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants