Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document feature flags #461

Closed
johanhelsing opened this issue Feb 2, 2024 · 3 comments · Fixed by #462
Closed

Document feature flags #461

johanhelsing opened this issue Feb 2, 2024 · 3 comments · Fixed by #462
Labels
documentation Improvements or additions to documentation

Comments

@johanhelsing
Copy link
Contributor

What problem did the developer encounter?

I ran into #421, and it seems I can work around it by enabling the ui and block_ui_interactions cargo features, however without reading the source code, it's unclear to me what these flags do and if they affect my app in an undesired way (apart from adding a bevy_ui dep)

What was the fix?

How could this be better documented?

Maybe it would be possible to explain it here?

https://docs.rs/crate/leafwing-input-manager/0.11.2/features

@johanhelsing johanhelsing added the documentation Improvements or additions to documentation label Feb 2, 2024
@alice-i-cecile
Copy link
Contributor

Oh super interesting. I don't know if / how we can generate docs that will show up there.

That said, we should definitely document these. Unless there's an answer to the above question, that belongs in the Cargo.toml where the flags are defined.

@Shute052
Copy link
Collaborator

Shute052 commented Feb 2, 2024

Unfortunately, writing documentation on the features page of the docs.rs is unfeasible. Nowadays, even for well-documented crates, most can only include the documentation as part of the index page. For example, ndarray and time. This limitation stems from the Rust official docs.rs generator, which exclusively compiles feature flags alongside their respective sub-features‘ name. Please refer to its template for more details.

Update: Existing Rust RFC is here

@alice-i-cecile
Copy link
Contributor

rust-lang/rust#96318 seems to be the upstream issue to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants