m2-mainnet Contracts Update #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpsanant
reviewed
Jan 8, 2024
gpsanant
reviewed
Jan 8, 2024
gpsanant
reviewed
Jan 8, 2024
wadealexc
reviewed
Jan 9, 2024
wadealexc
reviewed
Jan 9, 2024
wadealexc
reviewed
Jan 9, 2024
wadealexc
reviewed
Jan 9, 2024
gpsanant
reviewed
Jan 10, 2024
| bytes32 batchHeaderHash = batchHeader.hashBatchHeader(); | ||
| batchIdToBatchMetadataHashOptimistic[batchIdMemory] = EigenDAHasher.hashBatchHashedMetadata(batchHeaderHash, fee, uint32(block.number)); | ||
|
|
||
| emit BatchConfirmed(reducedBatchHeaderHash, batchIdMemory, fee, true); |
There was a problem hiding this comment.
this might mess up our indexing to add another param, so another event might be preferrable.
@mooselumph wdyt
mooselumph
reviewed
Jan 11, 2024
gpsanant
reviewed
Jan 12, 2024
gpsanant
reviewed
Jan 12, 2024
gpsanant
reviewed
Jan 12, 2024
jianoaix
reviewed
Jan 25, 2024
|
|
||
| emit BatchConfirmed(reducedBatchHeaderHash, batchIdMemory, fee); | ||
| emit BatchConfirmed(reducedBatchHeaderHash, batchIdMemory); |
There was a problem hiding this comment.
It seems a breaking change, what's the plan to handle this at indexer? I saw G commented this out as well but not yet addressed.
There was a problem hiding this comment.
Should be covered here: #192
Co-authored-by: steven <[email protected]>
Co-authored-by: siddimore <[email protected]> Co-authored-by: Ian Shim <[email protected]> Co-authored-by: bolatfurkan <[email protected]> Co-authored-by: Peter Straus <[email protected]> Co-authored-by: WELLINGTON MIRANDA BARBOSA <[email protected]> Co-authored-by: Wellington Barbosa <[email protected]> Co-authored-by: Jian Xiao <[email protected]> Co-authored-by: buldazer <[email protected]> Co-authored-by: Madhur Shrimal <[email protected]> Co-authored-by: Daniel Mancia <[email protected]> Co-authored-by: Jian Xiao <[email protected]>
Co-authored-by: quaq <[email protected]> Co-authored-by: QUAQ <[email protected]>
bxue-l2
pushed a commit
to bxue-l2/eigenda
that referenced
this pull request
Feb 2, 2024
Co-authored-by: Robert Raynor <[email protected]> Co-authored-by: Jian Xiao <[email protected]> Co-authored-by: steven <[email protected]> Co-authored-by: steven <[email protected]> Co-authored-by: siddimore <[email protected]> Co-authored-by: Ian Shim <[email protected]> Co-authored-by: bolatfurkan <[email protected]> Co-authored-by: Peter Straus <[email protected]> Co-authored-by: WELLINGTON MIRANDA BARBOSA <[email protected]> Co-authored-by: Wellington Barbosa <[email protected]> Co-authored-by: Jian Xiao <[email protected]> Co-authored-by: buldazer <[email protected]> Co-authored-by: Madhur Shrimal <[email protected]> Co-authored-by: Daniel Mancia <[email protected]>
bxue-l2
pushed a commit
to bxue-l2/eigenda
that referenced
this pull request
Feb 3, 2024
Co-authored-by: Robert Raynor <[email protected]> Co-authored-by: Jian Xiao <[email protected]> Co-authored-by: steven <[email protected]> Co-authored-by: steven <[email protected]> Co-authored-by: siddimore <[email protected]> Co-authored-by: Ian Shim <[email protected]> Co-authored-by: bolatfurkan <[email protected]> Co-authored-by: Peter Straus <[email protected]> Co-authored-by: WELLINGTON MIRANDA BARBOSA <[email protected]> Co-authored-by: Wellington Barbosa <[email protected]> Co-authored-by: Jian Xiao <[email protected]> Co-authored-by: buldazer <[email protected]> Co-authored-by: Madhur Shrimal <[email protected]> Co-authored-by: Daniel Mancia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Brings DA contracts up to date with middleware m2-mainnet
Implements IServiceManager interface for DASM
Checks