Component updates for M2 mainnet contracts #196
Conversation
| @@ -47,7 +47,7 @@ type churner struct { | |||
| mu sync.Mutex | |||
| Indexer thegraph.IndexedChainState | |||
| Transactor core.Transactor | |||
| QuorumCount uint16 | |||
| QuorumCount uint8 | |||
There was a problem hiding this comment.
The max of uint8 is 255, so it can have 256 quorums, and uint8 cannot represent 256.
There was a problem hiding this comment.
The onchain quorumCount was changed to a uint8 (https://github.com/Layr-Labs/eigenlayer-middleware/blob/98f884454d9e9de1e344bb6fba9a2cd3915e5b57/src/RegistryCoordinator.sol#L71), so it looks like we would only support up to 255 quorums.
There was a problem hiding this comment.
ok, so the range of quorum ID is [0, 254] (not [0, 255]).
| // if we should call the churner, call it | ||
| if shouldCallChurner { | ||
| churnReply, err := requestChurnApproval(ctx, operator, churnerUrl, useSecureGrpc, logger) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to request churn approval: %w", err) | ||
| } | ||
|
|
||
| return transactor.RegisterOperatorWithChurn(ctx, operator.KeyPair.PubKey, operator.Socket, operator.QuorumIDs, churnReply) | ||
| return transactor.RegisterOperatorWithChurn(ctx, operator.KeyPair, operator.Socket, operator.QuorumIDs, operator.PrivKey, salt, expiry, churnReply) |
There was a problem hiding this comment.
Need to update the nodeplugin path to have this private key as well: https://github.com/Layr-Labs/eigenda/blob/master/node/plugin/cmd/main.go#L118
There was a problem hiding this comment.
Good catch. Updated!
| } | ||
| metrics := NewMetrics(sdkClients.Metrics, sdkClients.PrometheusRegistry, logger, ":"+config.MetricsPort) | ||
| rpcCallsCollector := rpccalls.NewCollector(AppName, sdkClients.PrometheusRegistry) | ||
| // sdkClients, err := buildSdkClients(config, logger) |
There was a problem hiding this comment.
why was this commented out?
There was a problem hiding this comment.
At the time, the SDK hadn't been updated to reflect the new contracts. Since the client from the SDK was only being used for metrics, I created the metrics separately.
I'm not sure if it makes sense to build all of the SDK clients if we aren't using them.
My preference here would be to remove this commented code and create a ticket to track further integration with the SDK.
| @@ -47,7 +47,7 @@ type churner struct { | |||
| mu sync.Mutex | |||
| Indexer thegraph.IndexedChainState | |||
| Transactor core.Transactor | |||
| QuorumCount uint16 | |||
| QuorumCount uint8 | |||
There was a problem hiding this comment.
ok, so the range of quorum ID is [0, 254] (not [0, 255]).
|
As this has one approval, I'm merging for the stake of unblocking. Will continue to monitor comments and create additional PRs as needed. |
Why are these changes needed?
Checks